RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1811729 - [ESXi][RHEL8.2.1]open-vm-tools coverity scan issue
Summary: [ESXi][RHEL8.2.1]open-vm-tools coverity scan issue
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: open-vm-tools
Version: 8.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.2
Assignee: Cathy Avery
QA Contact: ldu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-09 15:52 UTC by Cathy Avery
Modified: 2020-09-15 03:32 UTC (History)
11 users (show)

Fixed In Version: open-vm-tools-11.0.5-3.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-21 15:30:14 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:3049 0 None None None 2020-07-21 15:30:20 UTC

Description Cathy Avery 2020-03-09 15:52:31 UTC
Comment 1 Cathy Avery 2020-03-09 15:58:31 UTC 
Coverity defect to be fixed

Error: RESOURCE_LEAK (CWE-772):
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:209: alloc_fn: Storage is returned from allocation function "g_io_channel_unix_new".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:209: var_assign: Assigning: "iochannel" = storage returned from "g_io_channel_unix_new(0)".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:214: noescape: Resource "iochannel" is not freed or pointed-to in "g_io_channel_read_to_end".
open-vm-tools-11.0.5-15389592/namespacetool/namespacetool.c:236: leaked_storage: Variable "iochannel" going out of scope leaks the storage it points to.
#  234|      }
#  235|      g_free(gErr);
#  236|->    return retVal;
#  237|   }
#  238|   


https://cov01.lab.eng.brq.redhat.com/covscanhub/task/163431/log/open-vm-tools-11.0.5-3.el8.cavery202003051014/scan-results-imp.err

Vmware is currently developing a fix.
Comment 2 Cathy Avery 2020-03-09 16:01:36 UTC 
This is not a major memory leak as according to vmware the tools exits soon after the leak.
Comment 3 jsaks 2020-03-09 20:00:13 UTC 
(In reply to Cathy Avery from comment #2)
> This is not a major memory leak as according to vmware the tools exits soon
> after the leak.

To clarify: this does not affect the vmtoolsd binary.  The only program affected is vmware-namespace-cmd; the resource leakage is minimal, and only occurs once (as opposed to in a loop); and the program exits shortly after returning from the function that leaks the memory.
Comment 4 jsaks 2020-03-18 15:57:42 UTC 
The fix for this is now available on https://github.com/vmware/open-vm-tools/tree/devel in file namespacetool/namespacetool.c.

Git commit 8dbd6e991315bb1b0a18c369c4d2bb165ef1f184 has the fix itself.

Git commit 95bb9273cccfd38e0f3299828a0a6cf5a8c30efb has the copyright update.  Please pick this up as well.
Comment 5 Cathy Avery 2020-03-27 14:03:07 UTC 
(In reply to jsaks from comment #4)
Thanks!
Comment 7 Cathy Avery 2020-03-27 16:22:12 UTC 
The latest covery
Comment 8 Cathy Avery 2020-03-27 16:24:50 UTC 
One more time ...

The coverity scan after applying the patch indicates no important errors.

https://cov01.lab.eng.brq.redhat.com/covscanhub/task/165280/
Comment 17 ldu 2020-05-15 02:22:51 UTC 
The covscan issue had been addressed by the path, the result could be found from https://errata.devel.redhat.com/advisory/53669/test_run/covscan
so change bug status to verified.
Comment 19 errata-xmlrpc 2020-07-21 15:30:14 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3049
Note You need to log in before you can comment on or make changes to this bug.