Bug 1811775 - Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions
Summary: Review Request: rubygem-semantic_puppet - Useful tools for working with Seman...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Terje Røsten
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-09 18:08 UTC by Breno
Modified: 2020-07-12 00:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-12 00:51:37 UTC
Type: ---
Embargoed:
terje.rosten: fedora-review+


Attachments (Terms of Use)

Description Breno 2020-03-09 18:08:34 UTC
Spec URL: https://raw.githubusercontent.com/skywalkerz0r/rubygem-semantic_puppet/epel8/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01298879-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

Comment 1 Robert-André Mauchin 🐧 2020-03-24 19:27:07 UTC
 - Valid license shorthand for Apache-2.0 is ASL 2.0

License: ASL 2.0

 - Remove these in %install, %exclude is to be used only for file exclusion between multiple packages:

%exclude %{gem_instdir}/.gitignore
%exclude %{gem_instdir}/.rubocop.yml
%exclude %{gem_instdir}/.travis.yml
%exclude %{gem_instdir}/.yardopts


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0". 28 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/rubygem-semantic_puppet/review-rubygem-
     semantic_puppet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[!]: Gem should use %gem_install macro.
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-semantic_puppet-1.0.2-1.fc33.noarch.rpm
          rubygem-semantic_puppet-doc-1.0.2-1.fc33.noarch.rpm
          rubygem-semantic_puppet-1.0.2-1.fc33.src.rpm
rubygem-semantic_puppet.noarch: W: invalid-license Apache-2.0
rubygem-semantic_puppet.noarch: W: no-documentation
rubygem-semantic_puppet-doc.noarch: W: invalid-license Apache-2.0
rubygem-semantic_puppet.src: W: invalid-license Apache-2.0
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Comment 2 Breno 2020-04-09 19:54:28 UTC
Spec URL: https://raw.githubusercontent.com/skywalkerz0r/rubygem-semantic_puppet/epel8/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01333826-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

Hi Robert-Andre',

Thanks for reviewing this package and I am sorry for the long delay.
With all this outbreak going on, I had a lot on my plate over here... well I bet it's kind of the same of us all.

Here are^^ the updates,

Thanks again.

Comment 3 Robert-André Mauchin 🐧 2020-04-13 18:34:32 UTC
You didn't fix this:

 - Remove these in %install, %exclude is to be used only for file exclusion between multiple packages:

%exclude %{gem_instdir}/.gitignore
%exclude %{gem_instdir}/.rubocop.yml
%exclude %{gem_instdir}/.travis.yml
%exclude %{gem_instdir}/.yardopts

Comment 4 Breno 2020-04-15 21:55:30 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01339252-rubygem-semantic_puppet/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01339252-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpmDescription: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb


Ooh, just pushed the changes.
Should be file now.

Thanks.

Comment 5 Breno 2020-04-16 01:35:49 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01339252-rubygem-semantic_puppet/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01339252-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

Ooh, just pushed the changes.
It should be fine now.

Thanks.

Comment 6 Breno 2020-04-24 15:40:00 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01342966-rubygem-semantic_puppet/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01342966-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

I've just made some updates in the spec file.

Comment 7 Terje Røsten 2020-05-02 12:27:45 UTC
Summary:

fix changelog and consider name change, the rest is fine.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
Please fix this.

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros
[?]: Package is named according to the Package Naming Guidelines.

For RPMS it's normal to us - over _, switch to rubygem-semantic-puppet ?

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
[-]: Description and summary sections in the package spec file contains
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: When checking ruby code, install the ruby plugin.
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-semantic_puppet-1.0.2-1.fc33.noarch.rpm
          rubygem-semantic_puppet-doc-1.0.2-1.fc33.noarch.rpm
          rubygem-semantic_puppet-1.0.2-1.fc33.src.rpm
rubygem-semantic_puppet.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
rubygem-semantic_puppet-doc.noarch: W: invalid-url URL: https://github.com/puppetlabs/semantic_puppet <urlopen error [Errno -2] Name or service not known>
rubygem-semantic_puppet.noarch: W: invalid-url URL: https://github.com/puppetlabs/semantic_puppet <urlopen error [Errno -2] Name or service not known>
rubygem-semantic_puppet.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 3 warnings.



Source checksums
----------------
https://rubygems.org/gems/semantic_puppet-1.0.2.gem :
  CHECKSUM(SHA256) this package     : 605be0ec9ca8354ece1da9481b58128327c48e68b1afa3cff96e5fde7221d510
  CHECKSUM(SHA256) upstream package : 605be0ec9ca8354ece1da9481b58128327c48e68b1afa3cff96e5fde7221d510


Requires
--------
rubygem-semantic_puppet (rpmlib, GLIBC filtered):
    ruby(rubygems)

rubygem-semantic_puppet-doc (rpmlib, GLIBC filtered):
    rubygem-semantic_puppet



Provides
--------
rubygem-semantic_puppet:
    rubygem(semantic_puppet)
    rubygem-semantic_puppet

rubygem-semantic_puppet-doc:
    rubygem-semantic_puppet-doc

Comment 8 Breno 2020-05-04 17:24:09 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01366544-rubygem-semantic_puppet/rubygem-semantic_puppet.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/brandfbb/puppet6-stable-el8-fedora/epel-8-x86_64/01366544-rubygem-semantic_puppet/rubygem-semantic_puppet-1.0.2-1.el8.src.rpm
Description: Tools used by Puppet to parse, validate, and compare Semantic Versions and
Version Ranges and to query and resolve module dependencies.
Fedora Account System Username: brandfbb

I've just made some updates in the spec file.

Hi Terje Røsten,

As for the specific rubygem packages' guidelines, it is required to keep the name as is in the UPSTREAM [1].
I updated the changelog as requested.

Thanks.

1 https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_naming_guidelines

Comment 9 Terje Røsten 2020-05-04 20:36:59 UTC
Thanks!

Comment 10 Terje Røsten 2020-05-04 20:37:34 UTC
Package  rubygem-semantic_puppet is

 APPROVED

Comment 11 Gwyn Ciesla 2020-05-08 19:00:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-semantic_puppet

Comment 12 Terje Røsten 2020-05-12 18:43:24 UTC
Please import the package source, build and close the ticket.

Comment 13 Terje Røsten 2020-06-20 08:36:59 UTC
ping?

Comment 14 Fedora Update System 2020-06-26 20:59:46 UTC
FEDORA-EPEL-2020-27598f5ff2 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-27598f5ff2

Comment 15 Fedora Update System 2020-06-27 03:17:33 UTC
FEDORA-EPEL-2020-27598f5ff2 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-27598f5ff2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2020-07-12 00:51:37 UTC
FEDORA-EPEL-2020-27598f5ff2 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.