Bug 1813198 - Added CD ROMs in UI other than Windows Guest Disk use VirtIO instead of sata
Summary: Added CD ROMs in UI other than Windows Guest Disk use VirtIO instead of sata
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.5.0
Assignee: Gilad Lekner
QA Contact: Radim Hrazdil
URL:
Whiteboard:
Depends On:
Blocks: 1817394
TreeView+ depends on / blocked
 
Reported: 2020-03-13 08:40 UTC by Radim Hrazdil
Modified: 2020-07-13 17:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1817394 (view as bug list)
Environment:
Last Closed: 2020-07-13 17:19:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (34.88 KB, image/png)
2020-05-20 09:30 UTC, Radim Hrazdil
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 5334 0 None closed Bug 1813198: Windows CDs use VirtIO instead of sata 2020-08-12 20:05:32 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:20:26 UTC

Internal Links: 2016296

Description Radim Hrazdil 2020-03-13 08:40:23 UTC
Description of problem:
When a user adds a CD ROM in UI other than windows guest tools, the interface is virtio, instead of SATA.

VM with CD ROM with virtio bus fails to boot due to:
server error. command SyncVMI failed: "LibvirtError(Code=67, Domain=10, Message='unsupported configuration: disk type 'virtio' of 'vdc' does not support ejectable media')"

There was a discussion about this issue in BZ1802001
which is for the moment being resolved by rejecting CDROMs with virtio bus. 

Therefore, UI should use sata for all CD ROM types.

Version-Release number of selected component (if applicable):
4.4.0-0.nightly-2020-03-06-170328

How reproducible:
100%

Steps to Reproduce:
1. Add a CD ROM to VM using UI modal dialog

Actual results:


Expected results:


Additional info:

Comment 1 Tomas Jelinek 2020-03-13 15:09:06 UTC
Given users will probably not attach any other cdroms in the wizard than the guest tools and, if they choose to add some, they can change the default in the UI to sata, I would not block the 4.4 on it. Still, I'd propose to get this to 4.4.1.
@Nelly: WDYT?

Comment 2 Nelly Credi 2020-03-16 07:43:11 UTC
ack on 4.4.1

Comment 4 Gilad Lekner 2020-05-03 10:58:02 UTC
wasn't this already fixed on https://github.com/openshift/console/pull/5035 ?

Comment 5 Radim Hrazdil 2020-05-03 13:39:59 UTC
@Gilad the PR 5035 fixes adding the CD from Details, but in the Wizard there is still virtio by default

Comment 6 Gilad Lekner 2020-05-06 14:00:37 UTC
PR - https://github.com/kubevirt/common-templates/pull/148
this bug is fixed through common-templates repo

Comment 7 Martin Sivák 2020-05-06 14:51:33 UTC
I do not believe the current version of that common-templates patch will fix the bug. Explained in the PR.

Comment 8 Yaacov Zamir 2020-05-17 13:44:06 UTC
@Gilad hi, can you make some order here :-)

a - what is the PR (or PRs) that need to be merged for this BZ to become modified ?
b - what is the current status of this PR (post or modified) ?

Comment 9 Gilad Lekner 2020-05-17 14:01:04 UTC
this BZ targets 4.4
https://bugzilla.redhat.com/show_bug.cgi?id=1817394 is a clone of this PR, and targets 4.5

Both are the same bug.
https://github.com/openshift/console/pull/5334 will fix the issue for 4.4 and then we will create another one for 4.5

Waiting for Review from Filip.

Comment 13 Radim Hrazdil 2020-05-20 09:29:20 UTC
IIUC, according to BZ1802001, VirtIO should not be considered an option for CD ROMs at all.
Currently, when user opens the CD Rom dialog in VM Wizard, VirtIO is selected by default.
That is incorrect, as we know beforehand that VM with VirtIO CD ROM will fail to be created.

Used console release-4.5 branch commit: 5994c64ee529b650bae348ef78ebc23dca8db5c5

Comment 14 Radim Hrazdil 2020-05-20 09:30:21 UTC
Created attachment 1690113 [details]
screenshot

Comment 15 Radim Hrazdil 2020-05-20 11:29:01 UTC
Gilad correctly pointed out that I was missing up to date common-templates, after updating it works as expected.
However, the fix is atm not present in release-4.5, so I'm moving this back to ON_QA

Comment 16 Guohua Ouyang 2020-05-21 04:21:08 UTC
Filed a new bug 1838397 for #13.

Comment 17 Radim Hrazdil 2020-05-21 12:48:29 UTC
Verified in release-4.5 branch, commit 531a1d33d7e03f487646c7569d5bce742501cb02

For Windows VMs: sata is the only interface type that is available in Wizard CD ROM dialog
For Linux OSes: VirtIO is still one of the options, but isn't marked as RECOMMENDED anymore.
We can handle that in BZ 1838397.

Comment 19 errata-xmlrpc 2020-07-13 17:19:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.