Bug 1813506 - Dockerfile not compatible with docker and buildah
Summary: Dockerfile not compatible with docker and buildah
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Container Storage
Classification: Red Hat Storage
Component: must-gather
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: OCS 4.6.0
Assignee: Pulkit Kundra
QA Contact: Aviad Polak
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-14 04:38 UTC by Ben Parees
Modified: 2020-12-17 06:22 UTC (History)
13 users (show)

Fixed In Version: 4.6.0-131.ci
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-17 06:22:27 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift ocs-operator pull 678 0 None closed must-gather: make Dockerfile compatible with docker and buildah 2021-01-12 15:01:05 UTC
Github openshift ocs-operator pull 809 0 None closed must-gather: make Dockerfile compatible with docker and buildah 2021-01-12 15:01:05 UTC
Github openshift ocs-operator pull 810 0 None closed bug 1813506: [release-4.6] must-gather: make Dockerfile compatible with docker and buildah 2021-01-12 15:01:05 UTC
Red Hat Product Errata RHSA-2020:5605 0 None None None 2020-12-17 06:22:58 UTC

Comment 2 Michael Adam 2020-03-18 22:31:57 UTC 
not 4.3 material
Comment 3 Jose A. Rivera 2020-04-08 14:50:48 UTC 
The line in question is this: https://github.com/openshift/ocs-operator/blob/master/must-gather/Dockerfile#L4

This seems an intentional use of the "bug". Ashish, is that the case? If so, do we still need to change anything?
Comment 4 Ben Parees 2020-04-08 15:26:02 UTC 
That line actually doesn't run into the bug because none of the files grabbed by the * are directories.  So you get the same behavior with imagebuilder and buildah/dockerfile for that.

You can either remove the trailing * (I do not believe it's needed here):
COPY collection-scripts/ /usr/bin/


Or just leave well enough alone and close this as not a bug.
Comment 5 Jose A. Rivera 2020-04-15 14:16:38 UTC 
The change is trivial enough, I'm fine with making it for the master branch at least. Moving this to OCS 4.5.
Comment 8 Raz Tamir 2020-06-29 06:43:28 UTC 
@Michael,

Could you please provide the steps to reproduce?
Comment 10 Jose A. Rivera 2020-06-29 15:19:59 UTC 
This is still not worth resolving right now, and we are approaching a deadline. Moving to OCS 4.6. But, since this is something for must-gather, changing the component.
Comment 16 Aviad Polak 2020-10-27 11:57:21 UTC 
checked must-gather-logs in ocs-operator.v4.6.0-113.ci
Comment 18 errata-xmlrpc 2020-12-17 06:22:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.6.0 security, bug fix, enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5605
Note You need to log in before you can comment on or make changes to this bug.