Bug 1813888

I see the repo is currently empty, with no code or a license file. Could we wait until there is some code on it?

Initial licensecheck output:

$ licensecheck -r .
./.gitreview: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache License (v2.0)
./README.rst: *No copyright* UNKNOWN
./molecule-requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache License
./setup.py: Apache License (v2.0)
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./playbooks/prepare-test-host.yml: Apache License (v2.0)
./scripts/run-local-test: Apache License (v2.0)
./tests/hosts.ini: *No copyright* UNKNOWN
./tripleo_ipa/.yamllint: *No copyright* UNKNOWN
./tripleo_ipa/README.md: *No copyright* UNKNOWN
./zuul.d/base.yaml: *No copyright* UNKNOWN
./zuul.d/layout.yaml: *No copyright* UNKNOWN
./tripleo_ipa/defaults/main.yml: *No copyright* UNKNOWN
./tripleo_ipa/handlers/main.yml: *No copyright* UNKNOWN
./tripleo_ipa/meta/main.yml: *No copyright* Creative Commons Attribution Public License (v4.0)
./tripleo_ipa/tasks/main.yml: *No copyright* UNKNOWN
./tripleo_ipa/tests/inventory: *No copyright* UNKNOWN
./tripleo_ipa/tests/test.yml: *No copyright* UNKNOWN
./tripleo_ipa/vars/main.yml: *No copyright* UNKNOWN
./zuul.d/playbooks/pre.yml: *No copyright* UNKNOWN
./zuul.d/playbooks/run-local.yml: *No copyright* UNKNOWN
./zuul.d/playbooks/run.yml: *No copyright* UNKNOWN
./tripleo_ipa/molecule/default/INSTALL.rst: *No copyright* UNKNOWN
./tripleo_ipa/molecule/default/converge.yml: *No copyright* UNKNOWN
./tripleo_ipa/molecule/default/molecule.yml: *No copyright* UNKNOWN
./tripleo_ipa/molecule/default/verify.yml: *No copyright* UNKNOWN

The code is written using the Apache 2.0 license. I have checked file tripleo_ipa/meta/main.yml, and the tool mistakenly assigned a Creative Commons license to the file. It's actually Apache 2.0, too.

Found below issues with fedora-review:-
- changelog is handled by DLRN package build tool
- %define is handled by DLRN package build tool
- source tarball is generated on the fly by DLRN package build tool
- ownership of /usr/share/ansible multiple packages,
  it's common for all similar ansible role packages
- %check absent, no unit test available for ansible role

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
     "*No copyright* Apache License", "Apache License (v2.0)". 32 files
     have unknown license. Detailed output of licensecheck in /tmp/ansible-
     tripleo-ipa/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/ansible(rhel-
     system-roles, ansible-config_template, ansible, ansible-pacemaker,
     tripleo-ansible), /usr/share/ansible/plugins(tripleo-ansible, ansible-
     pacemaker, openstack-tripleo-common, ansible-config_template),
     /usr/share/ansible/plugins/filter(tripleo-ansible),
     /usr/share/ansible/plugins/modules(tripleo-ansible, ansible-pacemaker,
     ansible-config_template, ansible-freeipa),
     /usr/share/ansible/roles(openstack-tripleo-common, ansible-role-atos-
     hsm, ansible-role-redhat-subscription, ansible-role-container-
     registry, rhel-system-roles, ansible-role-tripleo-modify-image,
     ansible-role-chrony, tripleo-ansible, ansible-role-thales-hsm,
     ansible-role-openstack-operations, ansible-tripleo-ipsec),
     /usr/share/ansible/tripleo-playbooks(tripleo-ansible)
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     0.0.1.dev13
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: ansible-tripleo-ipa-0.0.1-0.20200331152234.ac02238.el8.noarch.rpm
          ansible-tripleo-ipa-0.0.1-0.20200331152234.ac02238.el8.src.rpm
ansible-tripleo-ipa.noarch: E: no-changelogname-tag
ansible-tripleo-ipa.noarch: E: non-executable-script /usr/share/ansible/plugins/filter/service_metadata.py 644 /usr/bin/python 
ansible-tripleo-ipa.noarch: E: non-executable-script /usr/share/ansible/plugins/modules/cleanup_ipa_services.py 644 /usr/bin/python 
ansible-tripleo-ipa.src: E: no-changelogname-tag
ansible-tripleo-ipa.src: W: invalid-url Source0: tripleo-ipa-0.0.1.dev13-0.20200331152234.ac02238.tar.gz
2 packages and 0 specfiles checked; 4 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
ansible-tripleo-ipa.noarch: E: no-changelogname-tag
ansible-tripleo-ipa.noarch: W: invalid-url URL: https://opendev.org/x/tripleo-ipa/ <urlopen error [Errno -2] Name or service not known>
ansible-tripleo-ipa.noarch: E: non-executable-script /usr/share/ansible/plugins/filter/service_metadata.py 644 /usr/bin/python 
ansible-tripleo-ipa.noarch: E: non-executable-script /usr/share/ansible/plugins/modules/cleanup_ipa_services.py 644 /usr/bin/python 
1 packages and 0 specfiles checked; 3 errors, 1 warnings.



Requires
--------
ansible-tripleo-ipa (rpmlib, GLIBC filtered):
    ansible-freeipa
    python(abi)
    python3-PyYAML
    python3-six
    python3-urllib-gssapi



Provides
--------
ansible-tripleo-ipa:
    ansible-tripleo-ipa
    python3.6dist(tripleo-ipa)
    python3dist(tripleo-ipa)




Package is Approved.

tripleo-ipa available since train, closing it.