Bug 1813907 - mom fails to build with Python 3.9: threading.Thread.isAlive() was removed
Summary: mom fails to build with Python 3.9: threading.Thread.isAlive() was removed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: mom
Classification: oVirt
Component: General
Version: 0.5.16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.4.1
: ---
Assignee: Ryan Barry
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks: 1791976 F33FTBFS
TreeView+ depends on / blocked
 
Reported: 2020-03-16 13:07 UTC by Sandro Bonazzola
Modified: 2021-05-13 06:25 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-16 07:19:50 UTC
oVirt Team: Virt
Embargoed:
rbarry: ovirt-4.4?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 108074 0 master MERGED Change Threading.isAlive() to is_alive() 2021-01-26 12:48:43 UTC

Description Sandro Bonazzola 2020-03-16 13:07:11 UTC
This bug was initially created as a copy of Bug #1791976

I am copying this bug because: 



mom fails to build with Python 3.9.0a2.

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib64/python3.9/threading.py", line 944, in _bootstrap_inner
    self.run()
  File "/usr/lib64/python3.9/threading.py", line 882, in run
    self._target(*self._args, **self._kwargs)
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 60, in run
    self._wait_for_thread(rpc_server, 5)
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 217, in _wait_for_thread
    if t.isAlive():
AttributeError: 'RPCServer' object has no attribute 'isAlive'
    self.run()
  File "/usr/lib64/python3.9/threading.py", line 882, in run
    self._target(*self._args, **self._kwargs)
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 60, in run
    self._wait_for_thread(rpc_server, 5)
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 217, in _wait_for_thread
    if t.isAlive():
AttributeError: 'RPCServer' object has no attribute 'isAlive'
2020-01-16 17:32:00,488 - mom - ERROR - Failed to initialize MOM threads
Traceback (most recent call last):
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 28, in run
    hypervisor_iface = self.get_hypervisor_interface()
  File "/builddir/build/BUILD/mom-0.5.16/mom/__init__.py", line 226, in get_hypervisor_interface
    return module.instance(self.config)
AttributeError: module 'mom.HypervisorInterfaces.libvirtInterface' has no attribute 'instance'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The isAlive() method of threading.Thread has been removed. It was deprecated since Python 3.8. Use is_alive() instead."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01148598-mom/

For all our attempts to build mom with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/mom/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Martin Sivák 2020-03-16 13:21:00 UTC
This is safe to change. The `is_alive` spelling has been available since Python 2.6. https://docs.python.org/2/library/threading.html#threading.Thread.is_alive

Comment 2 Miro Hrončok 2020-05-25 13:01:34 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 3 Miro Hrončok 2020-05-29 07:11:34 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 4 Charalampos Stratakis 2020-06-03 17:36:08 UTC
PR: https://src.fedoraproject.org/rpms/mom/pull-request/2


Note You need to log in before you can comment on or make changes to this bug.