Spec URL: https://fbo.fedorapeople.org/python-apscheduler/python-APScheduler.spec SRPM URL: https://fbo.fedorapeople.org/python-apscheduler/python-APScheduler-3.6.3-1.fc33.src.rpm Description: Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule your Python code to be executed later, either just once or periodically. You can add new jobs or remove old ones on the fly as you please. If you store your jobs in a database, they will also survive scheduler restarts and maintain their state. When the scheduler is restarted, it will then run all the jobs it should have run while it was offline. Fedora Account System Username: fbo
spec looks sane. running automated checks.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Please fix: E: description-line-too-long C Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 115 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-APScheduler-3.6.3-1.fc33.noarch.rpm python-APScheduler-3.6.3-1.fc33.src.rpm python3-APScheduler.noarch: E: description-line-too-long C Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule python3-APScheduler.noarch: E: description-line-too-long C add new jobs or remove old ones on the fly as you please. If you store your jobs in python3-APScheduler.noarch: E: description-line-too-long C When the scheduler is restarted, it will then run all the jobs it should have run python-APScheduler.src: E: description-line-too-long C Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule python-APScheduler.src: E: description-line-too-long C add new jobs or remove old ones on the fly as you please. If you store your jobs in python-APScheduler.src: E: description-line-too-long C When the scheduler is restarted, it will then run all the jobs it should have run 2 packages and 0 specfiles checked; 6 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python3-APScheduler.noarch: E: description-line-too-long C Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule python3-APScheduler.noarch: E: description-line-too-long C add new jobs or remove old ones on the fly as you please. If you store your jobs in python3-APScheduler.noarch: E: description-line-too-long C When the scheduler is restarted, it will then run all the jobs it should have run python3-APScheduler.noarch: W: invalid-url URL: http://pythonhosted.org/APScheduler/ <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 3 errors, 1 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/A/APScheduler/APScheduler-3.6.3.tar.gz : CHECKSUM(SHA256) this package : 3bb5229eed6fbbdafc13ce962712ae66e175aa214c69bed35a06bffcf0c5e244 CHECKSUM(SHA256) upstream package : 3bb5229eed6fbbdafc13ce962712ae66e175aa214c69bed35a06bffcf0c5e244 Requires -------- python3-APScheduler (rpmlib, GLIBC filtered): python(abi) python3.8dist(pytz) python3.8dist(setuptools) python3.8dist(six) python3.8dist(tzlocal) Provides -------- python3-APScheduler: python-APScheduler python3-APScheduler python3.8dist(apscheduler) python3dist(apscheduler) Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 1813957 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, Ruby, Ocaml, Haskell, Java, C/C++, SugarActivity, Perl, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
E: description-line-too-long C Advanced Python Scheduler (APScheduler) is a Python library that lets you schedule -> fixed.
APPROVED. Do not request a new repo, as the repo already exists. Request package unretirement via https://pagure.io/releng/new_issue?template=package_unretirement
Ok. Clicking on the Pagure project "retire" to "adopt it" links to https://pagure.io/releng/new_issue?title=Unretire%20rpms/python-APScheduler which is not the same template. Is there any differences ?
I didn't know there is that link. I will make sure that link uses the template. https://pagure.io/releng/new_issue?template=package_unretirement&title=Unretire%20rpms/python-APScheduler The unretire template has better questions.
https://pagure.io/pagure/pull-request/4771