RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1814307 - New package: ovn-octavia-provider
Summary: New package: ovn-octavia-provider
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: trunk
Assignee: hguemar
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-17 15:29 UTC by Maciej Józefczyk
Modified: 2020-07-07 13:36 UTC (History)
2 users (show)

Fixed In Version: python-ovn-octavia-provider-0.1.0-1.el8
Clone Of:
Environment:
Last Closed: 2020-07-07 13:36:39 UTC
Embargoed:
amoralej: rdo-review+


Attachments (Terms of Use)

Description Maciej Józefczyk 2020-03-17 15:29:14 UTC
Hello there,

OVN Octavia provider has been extracted from networking-ovn project to dedicated repository.

Upstream code repository, under Openstack/Neutron umbrella:

https://opendev.org/openstack/ovn-octavia-provider/

The licence is Apache 2.0.

Thank you!

Comment 1 Alfredo Moralejo 2020-03-17 15:40:15 UTC
$ licensecheck -r .
./.gitreview: *No copyright* UNKNOWN
./.pylintrc: *No copyright* UNKNOWN
./.stestr.conf: *No copyright* UNKNOWN
./CONTRIBUTING.rst: *No copyright* UNKNOWN
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache License (v2.0)
./README.rst: *No copyright* UNKNOWN
./lower-constraints.txt: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache License
./setup.py: Apache License (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./devstack/local.conf.sample: *No copyright* UNKNOWN
./doc/requirements.txt: *No copyright* UNKNOWN
./ovn_octavia_provider/driver.py: Apache License (v2.0)
./ovn_octavia_provider/i18n.py: *No copyright* Apache License (v2.0)
./playbooks/configure_functional_job.yaml: *No copyright* UNKNOWN
./playbooks/post_functional_job.yaml: *No copyright* UNKNOWN
./playbooks/run_functional_job.yaml: *No copyright* UNKNOWN
./tools/check_unit_test_structure.sh: *No copyright* UNKNOWN
./tools/coding-checks.sh: *No copyright* UNKNOWN
./tools/pip_install_src_modules.sh: *No copyright* UNKNOWN
./zuul.d/base.yaml: *No copyright* UNKNOWN
./zuul.d/project.yaml: *No copyright* UNKNOWN
./doc/source/conf.py: *No copyright* Apache License (v2.0)
./doc/source/index.rst: Apache License (v2.0)
./doc/source/pdf-index.rst: Apache License (v2.0)
./ovn_octavia_provider/common/config.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/common/constants.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/common/exceptions.py: Apache License (v2.0)
./ovn_octavia_provider/common/utils.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/hacking/checks.py: Apache License (v2.0)
./ovn_octavia_provider/ovsdb/impl_idl_ovn.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/ovsdb/ovsdb_monitor.py: Apache License (v2.0)
./releasenotes/notes/new-repository-for-ovn-octavia-provider-driver-dd81c4414c529c4e.yaml: *No copyright* UNKNOWN
./releasenotes/notes/ovn-octavia-provider-driver-multiple-protocols-4a93e184b8f374c7.yaml: *No copyright* UNKNOWN
./releasenotes/source/conf.py: *No copyright* Apache License (v2.0) GENERATED FILE
./releasenotes/source/index.rst: *No copyright* UNKNOWN
./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN
./roles/configure_functional_tests/README.rst: *No copyright* UNKNOWN
./roles/fetch_journal_log/README.rst: *No copyright* UNKNOWN
./roles/setup_logdir/README.rst: *No copyright* UNKNOWN
./doc/source/admin/driver.rst: *No copyright* UNKNOWN
./doc/source/admin/index.rst: *No copyright* UNKNOWN
./doc/source/contributor/index.rst: *No copyright* UNKNOWN
./doc/source/contributor/loadbalancer.rst: *No copyright* UNKNOWN
./ovn_octavia_provider/tests/functional/requirements.txt: *No copyright* UNKNOWN
./ovn_octavia_provider/tests/functional/test_driver.py: Apache License (v2.0)
./ovn_octavia_provider/tests/unit/fakes.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/tests/unit/test_driver.py: *No copyright* Apache License (v2.0)
./ovn_octavia_provider/tests/unit/test_hacking.py: Apache License (v2.0)
./roles/configure_functional_tests/defaults/main.yaml: *No copyright* UNKNOWN
./roles/configure_functional_tests/tasks/main.yaml: *No copyright* UNKNOWN
./roles/fetch_journal_log/defaults/main.yaml: *No copyright* UNKNOWN
./roles/fetch_journal_log/tasks/main.yaml: *No copyright* UNKNOWN
./roles/setup_logdir/defaults/main.yaml: *No copyright* UNKNOWN
./roles/setup_logdir/tasks/main.yaml: *No copyright* UNKNOWN
./ovn_octavia_provider/tests/unit/schemas/ovn-nb.ovsschema: *No copyright* UNKNOWN

License is correct ASL 2.0

Please go ahead and add the package to rdoinfo repo.

Comment 2 Maciej Józefczyk 2020-03-17 16:00:11 UTC
rdoinfo change: https://review.rdoproject.org/r/#/c/25961/

Comment 3 Alfredo Moralejo 2020-04-03 09:27:30 UTC
Fedora review result:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
     "*No copyright* Apache License", "Apache License (v2.0)". 52 files
     have unknown license. Detailed output of licensecheck in /tmp/python-
     ovn-octavia-provider/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-ovn-octavia-provider , python3-ovn-octavia-provider-tests
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
     0.0.1.dev36
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-ovn-octavia-provider-0.0.1-0.20200402090008.6e7f454.el8.noarch.rpm
          python3-ovn-octavia-provider-tests-0.0.1-0.20200402090008.6e7f454.el8.noarch.rpm
          python-ovn-octavia-provider-0.0.1-0.20200402090008.6e7f454.el8.src.rpm
python3-ovn-octavia-provider.noarch: E: no-changelogname-tag
python3-ovn-octavia-provider.noarch: W: no-documentation
python3-ovn-octavia-provider-tests.noarch: E: no-changelogname-tag
python3-ovn-octavia-provider-tests.noarch: W: no-documentation
python-ovn-octavia-provider.src: E: no-changelogname-tag
python-ovn-octavia-provider.src: W: invalid-url Source0: ovn-octavia-provider-0.0.1.dev36-0.20200402090008.6e7f454.tar.gz
3 packages and 0 specfiles checked; 3 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
python3-ovn-octavia-provider-tests.noarch: E: no-changelogname-tag
python3-ovn-octavia-provider-tests.noarch: W: invalid-url URL: https://opendev.org/openstack/ovn-octavia-provider <urlopen error [Errno -2] Name or service not known>
python3-ovn-octavia-provider-tests.noarch: W: no-documentation
python3-ovn-octavia-provider.noarch: E: no-changelogname-tag
python3-ovn-octavia-provider.noarch: W: invalid-url URL: https://opendev.org/openstack/ovn-octavia-provider <urlopen error [Errno -2] Name or service not known>
python3-ovn-octavia-provider.noarch: W: no-documentation
2 packages and 0 specfiles checked; 2 errors, 4 warnings.



Requires
--------
python3-ovn-octavia-provider (rpmlib, GLIBC filtered):
    python(abi)
    python3-babel
    python3-keystoneauth1
    python3-netaddr
    python3-neutron-lib
    python3-neutronclient
    python3-octavia-lib
    python3-openvswitch
    python3-oslo-config
    python3-oslo-log
    python3-oslo-serialization
    python3-oslo-utils
    python3-ovsdbapp
    python3-pbr
    python3-tenacity

python3-ovn-octavia-provider-tests (rpmlib, GLIBC filtered):
    python(abi)
    python3-neutron-lib-tests
    python3-neutron-tests
    python3-oslotest
    python3-ovn-octavia-provider
    python3-stestr
    python3-testresources
    python3-testscenarios
    python3-testtools
    python3-webtest



Provides
--------
python3-ovn-octavia-provider:
    python3-ovn-octavia-provider
    python3.6dist(ovn-octavia-provider)
    python3dist(ovn-octavia-provider)

python3-ovn-octavia-provider-tests:
    python3-ovn-octavia-provider-tests



Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18
Command line :/usr/bin/fedora-review -m centos-8-dlrn -r -rn python-ovn-octavia-provider-0.0.1-0.20200402090008.6e7f454.el8.src.rpm
Buildroot used: dlrn-centos8-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: fonts, R, Haskell, C/C++, SugarActivity, Ocaml, Perl, PHP, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


Some notes:

- no changelog as the spec is ready for DLRN
- tarball is generated by DLRN, we can ignore the invalid-url error

The package is APPROVED

Comment 4 Alfredo Moralejo 2020-07-07 13:36:39 UTC
Package python-ovn-octavia-provider-0.1.0-1.el8 is included in RDO Ussuri.


Note You need to log in before you can comment on or make changes to this bug.