Spec Name or Url: http://people.redhat.com/roland/tmp/lcov.spec SRPM Name or Url: http://people.redhat.com/roland/tmp/lcov-1.4-1.src.rpm Description: LCOV is an extension of GCOV, a GNU tool which provides information about what parts of a program are actually executed (i.e. "covered") while running a particular test case. The extension consists of a set of PERL scripts which build on the textual GCOV output to implement HTML output and support for large projects.
only one note to the spec - empty %build => should be omitted And as this looks as a uncomplicated package I could do a my first formal package review.
The file for Source0 at URL http://ltp.sourceforge.net/coverage/tools/lcov-%{version}.tar.gz doesn't exist, use http://dl.sf.net/ltp/lcov-%{version}.tar.gz instead.
Dan, were you going to review this? It's still unassigned and blocking FE-NEW. You should assign it to yourself and make it block FW-REVIEW instead, or let me know and I'll review it.
I've put a new version in http://people.redhat.com/roland/tmp/ that addresses the reviewers' comments and fixes another bug.
Good: - rpmlint clean - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, matches source - spec file legible, in am. english - source matches upstream - package is noarch without a %build section and builds on FC4 (i386) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - works for me APPROVED
Built in devel.
Please add the package in owners.list
I added it to owners.list; I don't know if any more magic is required.
Thanks. It all looks fine now, I think. No additional magic required :-)
Package Change Request ====================== Package Name: lcov New Branches: EL-4 EL-5 Owners: roland
cvs done.