%license files are missing from %files.

(In reply to Igor Gnatenko from comment #1)
> %license files are missing from %files.

thanks, upstream doesn't have one, is that required?

Yes. There are ton of MIT variants and we need to know which one it is..

I did not look in upstream, but I guess this is just about copying LICENSE file into subfolder for -sys crate and publishing new version. At least contact upstream please and put link in spec file.

Apparently, "MIT" is unambiguously https://spdx.org/licenses/MIT.

Do you think it's still required? I am upstream, fwiw.

(In reply to Marc-Andre Lureau from comment #4)
> Apparently, "MIT" is unambiguously https://spdx.org/licenses/MIT.

Yes, but in the world exists at least 30+ variations of MIT licenses. Better ask @spot about this :)

> Do you think it's still required? I am upstream, fwiw.

Yes. It should not be hard to put the full license text into LICENSE file and release new version, isn't it?

Updated:

Spec URL: https://elmarco.fedorapeople.org/rust-libslirp-sys.spec
SRPM URL: https://elmarco.fedorapeople.org/rust-libslirp-sys-4.0.2-1.fc32.src.rpm

LGTM.

Just a few notes:

* You probably forgot to git push in upstream repo
*         pkg_config::find_library("slirp").unwrap(); suggests that any version will work, but in spec file you have >= 4.0.0, you probably want to either drop that part in spec or add some restriction in upstream.

(In reply to Igor Gnatenko from comment #7)
> LGTM.
> 
> Just a few notes:
> 
> * You probably forgot to git push in upstream repo

done

> *         pkg_config::find_library("slirp").unwrap(); suggests that any
> version will work, but in spec file you have >= 4.0.0, you probably want to
> either drop that part in spec or add some restriction in upstream.

I added >= 4.0.0 there too.

thanks

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libslirp-sys