Description of problem: openstack network manager refresh fails due to old logging code getting an ERROR -- : [NoMethodError]: undefined method `address' for nil:NilClass Method:[block (2 levels) in <class:LogProxy>] because of the following line: _log.warn "Forbidden response code returned in provider: #{@os_handle.address}. Message=#{err.message}"" looks like that error message was written for "old" refresh the new inventory/collector doesn't have an @os_handle see comment 10 in https://bugzilla.redhat.com/show_bug.cgi?id=1803745 for trace Version-Release number of selected component (if applicable): 5.11.4.2.20200309205646_632ff59 How reproducible: every time Steps to Reproduce: 1. add openstack provider, trigger a refresh 2. 3. Actual results: Expected results: Additional info:
Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set the severity to Low.
Based on provided backtrace, the error was raised in rescue block for Forbidden error. The forbidden error can happen and not stop the refresh, but the warning log output used @os_handle which is not propably provied by ovirt provider. Update rescue block to ignore nil @os_handle. If there is an original ovirt environment where this error appeared I could use for ensuring this was the only problem, please provide me the access. https://github.com/ManageIQ/manageiq-providers-openstack/pull/576
New commit detected on ManageIQ/manageiq-providers-openstack/master: https://github.com/ManageIQ/manageiq-providers-openstack/commit/e2eb354daa2af6b8d778289a7d115774248e2a1f commit e2eb354daa2af6b8d778289a7d115774248e2a1f Author: Marek Aufart <maufart> AuthorDate: Fri Apr 3 13:14:26 2020 +0000 Commit: Marek Aufart <maufart> CommitDate: Fri Apr 3 13:14:26 2020 +0000 Update Network Refresh error logging for not-OpenStack provider A logic for catch/rescue errors for refresh uses @os_handle for warn logging. RHV/ovirt provider uses OpenStack networking, but doesn't provide @os_handle. Updating warn error output to use @manager variable with ignore if nil to allow pass refresh even with skipped records (as until how, just logging raised the error). Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1815479 app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb | 8 +- 1 file changed, 4 insertions(+), 4 deletions(-)
New commit detected on ManageIQ/manageiq-providers-openstack/ivanchuk: https://github.com/ManageIQ/manageiq-providers-openstack/commit/949892c77d89109704807e348b1f13847c278ccb commit 949892c77d89109704807e348b1f13847c278ccb Author: Adam Grare <agrare> AuthorDate: Fri Apr 3 17:24:01 2020 +0000 Commit: Adam Grare <agrare> CommitDate: Fri Apr 3 17:24:01 2020 +0000 Merge pull request #576 from aufi/fix_error_handling_outside_openstack_provider Update Network Refresh error logging for not-OpenStack provider (cherry picked from commit fc1ddbec89cb1d402f50b51eb9c9423c32623f8f) https://bugzilla.redhat.com/show_bug.cgi?id=1815479 app/models/manageiq/providers/openstack/refresh_parser_common/helper_methods.rb | 8 +- 1 file changed, 4 insertions(+), 4 deletions(-)
Network manager refresh was not triggered after creating as sec group
https://github.com/ManageIQ/manageiq-providers-openstack/pull/525
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:2480