Spec URL: https://ekulik.fedorapeople.org/python-pg8000.spec SRPM URL: https://ekulik.fedorapeople.org/python-pg8000-1.14.0-1.fc33.src.rpm Description: pg8000 is a pure-Python PostgreSQL driver that complies with DB-API 2.0. The driver communicates with the database using the PostgreSQL Backend / Frontend Protocol. Fedora Account System Username: ekulik
This is a retired package in Fedora. I want to bring it back to be able to build a newer version of python-testing.postgresql.
Copr build: https://copr.fedorainfracloud.org/coprs/ekulik/python-pg8000/build/1314594/
Taking this review.
The changelog section is empty. Can you restore the changelog from the original package spec?
(In reply to Neal Gompa from comment #4) > The changelog section is empty. Can you restore the changelog from the > original package spec? Oh, yes, sorry.
Spec URL: https://ekulik.fedorapeople.org/python-pg8000.spec SRPM URL: https://ekulik.fedorapeople.org/python-pg8000-1.14.0-1.fc33.src.rpm
Initial review comments: > BuildRequires: python3-setuptools I'd suggest using "python3dist(setuptools)" here. > Suggests: python3-sqlalchemy I'd suggest using "Enhances: python3dist(sqlalchemy)" here. It's a reverse hint, not a forward one. > Suggests: postgresql Why are you suggesting this? This doesn't use the PostgreSQL clients at all...
(In reply to Neal Gompa from comment #7) > Initial review comments: > > > BuildRequires: python3-setuptools > > I'd suggest using "python3dist(setuptools)" here. Sure thing. > > Suggests: python3-sqlalchemy > > I'd suggest using "Enhances: python3dist(sqlalchemy)" here. It's a reverse > hint, not a forward one. Will do. > > Suggests: postgresql > > Why are you suggesting this? This doesn't use the PostgreSQL clients at > all... You have to realize that there is historical baggage and that someone already approved the changes, so I’m not questioning everything I come in touch with. I did, however, find https://bugzilla.redhat.com/show_bug.cgi?id=1304522#c8, so seems that it can go.
Argh, the package is not installable due to an unmet dependency on https://pypi.org/project/scramp/.
Spec URL: https://ekulik.fedorapeople.org/python-pg8000.spec SRPM URL: https://ekulik.fedorapeople.org/python-pg8000-1.14.0-1.fc33.src.rpm Including this for posterity. I’m not going to maintain additional packages just for this.
(In reply to Ernestas Kulik from comment #10) > I’m not going to maintain additional packages just for this. It looks like it's in the review queue already. So you might want to consider reopening?
I might need pg8000 in the future.
lets finish this, please review.
More comments: > %pycached %{python3_sitelib}/%{pypi_name}/__init__.py > %pycached %{python3_sitelib}/%{pypi_name}/core.py > %pycached %{python3_sitelib}/%{pypi_name}/_version.py This is completely unnecessary for this module, please just use "%{python3_sitelib}/%{pypi_name}/"
(In reply to Neal Gompa from comment #14) > More comments: > > > %pycached %{python3_sitelib}/%{pypi_name}/__init__.py > > %pycached %{python3_sitelib}/%{pypi_name}/core.py > > %pycached %{python3_sitelib}/%{pypi_name}/_version.py > > This is completely unnecessary for this module, please just use > "%{python3_sitelib}/%{pypi_name}/" Then for what modules would it be necessary? I much prefer spelling out every single file so that I know if something disappears either intentionally or not.
(In reply to Ernestas Kulik from comment #15) > (In reply to Neal Gompa from comment #14) > > More comments: > > > > > %pycached %{python3_sitelib}/%{pypi_name}/__init__.py > > > %pycached %{python3_sitelib}/%{pypi_name}/core.py > > > %pycached %{python3_sitelib}/%{pypi_name}/_version.py > > > > This is completely unnecessary for this module, please just use > > "%{python3_sitelib}/%{pypi_name}/" > > Then for what modules would it be necessary? I much prefer spelling out > every single file so that I know if something disappears either > intentionally or not. %pycached was created to make it easier to package Python modules that just ship a file into %python3_sitelib and capture the cache file along with it. While you can certainly use it with a module that installs properly into a directory providing a namespace, there's no point and any separation would just break the module anyway. You're not subpackaging within that folder tree, so why pretend like you might?
*** This bug has been marked as a duplicate of bug 1825716 ***
https://bodhi.fedoraproject.org/updates/FEDORA-2020-98a167c578 https://koji.fedoraproject.org/koji/buildinfo?buildID=1497248
FEDORA-2020-8bd55aa329 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bd55aa329
FEDORA-2020-3e25dca79a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3e25dca79a
FEDORA-2020-3e25dca79a has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-3e25dca79a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3e25dca79a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-8bd55aa329 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8bd55aa329 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bd55aa329 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-3e25dca79a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-8bd55aa329 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.