Bug 1816577 - fixup virtiofs socket paths
Summary: fixup virtiofs socket paths
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: libvirt
Version: 8.2
Hardware: All
OS: Linux
high
medium
Target Milestone: rc
: 8.0
Assignee: Ján Tomko
QA Contact: yafu
URL:
Whiteboard:
Depends On:
Blocks: 1677408 1707874
TreeView+ depends on / blocked
 
Reported: 2020-03-24 10:14 UTC by Ján Tomko
Modified: 2021-09-03 16:55 UTC (History)
10 users (show)

Fixed In Version: libvirt-6.0.0-15.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-05 09:59:00 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-39727 0 None None None 2021-09-03 16:55:11 UTC
Red Hat Product Errata RHBA-2020:2017 0 None None None 2020-05-05 09:59:43 UTC

Description Ján Tomko 2020-03-24 10:14:54 UTC
Description of problem:
There are some inconsistencies in the paths internally used by libvirt

Version-Release number of selected component (if applicable):
libvirt-6.0.0-14.module+el8.2.0+6069+78a1cb09

How reproducible:
100 %

Steps to Reproduce:
1. start a domain with virtiofs
2. ls -1 /var/lib/libvirt/qemu/*<domain_name>/*fs*

Actual results:
/var/lib/libvirt/qemu/domain-2-f31/2-f31-fs0-virtiofsd.pid
/var/lib/libvirt/qemu/domain-2-f31/fs0-virtiofsd.sock

Expected results:
/var/lib/libvirt/qemu/domain-2-f31/fs0-fs.pid
/var/lib/libvirt/qemu/domain-2-f31/fs0-fs.sock


Additional info:

Comment 1 Ján Tomko 2020-03-24 10:28:45 UTC
Pushed upstream as:
commit 223b370aaa6fcbcbfbd4045fde4ae67e047180ad
Author:     Ján Tomko <jtomko>
CommitDate: 2020-03-24 11:16:29 +0100

    qemu: virtiofs: shorten socket filename
    
    Use just 'fs' instead of 'virtiofsd'.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1816577
    
    Signed-off-by: Ján Tomko <jtomko>
    Reviewed-by: Michal Privoznik <mprivozn>

commit 7055af6c2253666cd0b7c4c459c5a019da789140
Author:     Ján Tomko <jtomko>
CommitDate: 2020-03-24 11:16:24 +0100

    qemu: virtiofs: shorten pid filename
    
    There is no need to repeat the shortName, since it's
    already present in the directory path.
    
    Also use just 'fs' instead of 'virtiofsd'.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1816577
    
    Signed-off-by: Ján Tomko <jtomko>
    Suggested-by: Andrea Bolognani <abologna>
    Reviewed-by: Michal Privoznik <mprivozn>

git describe: v6.1.0-224-g223b370aaa

Comment 8 yafu 2020-03-26 08:58:16 UTC
Verified with libvirt-6.0.0-15.el8.x86_64.

Test steps:
1.Start a guest with multiple virtiofs filesystem devices:
#virsh dumpxml vm1
...
  <filesystem type='mount' accessmode='passthrough'>
      <driver type='virtiofs' queue='1024'/>
      <binary path='/usr/libexec/virtiofsd' xattr='on'>
        <lock posix='on' flock='on'/>
      </binary>
      <source dir='/path1'/>
      <target dir='mount_tag'/>
      <alias name='fs0'/>
      <address type='pci' domain='0x0000' bus='0x06' slot='0x00' function='0x0'/>
    </filesystem>
    <filesystem type='mount' accessmode='passthrough'>
      <driver type='virtiofs'/>
      <binary path='/usr/libexec/virtiofsd' xattr='on'>
        <cache mode='always'/>
        <lock posix='on' flock='on'/>
      </binary>
      <source dir='/path2'/>
      <target dir='mount_tag1'/>
      <alias name='fs1'/>
      <address type='pci' domain='0x0000' bus='0x08' slot='0x00' function='0x0'/>
    </filesystem>
    <filesystem type='mount' accessmode='passthrough'>
      <driver type='virtiofs'/>
      <binary path='/usr/libexec/virtiofsd'/>
      <source dir='/path3'/>
      <target dir='mount_tag2'/>
      <alias name='ua-1035e984-8238-46e1-bf56-b546246e1a39'/>
      <address type='pci' domain='0x0000' bus='0x09' slot='0x00' function='0x0'/>
    </filesystem>
...

2.Check viriofs pid and socket file:
## ll /var/lib/libvirt/qemu/domain-2-vm1/
total 20
-rw-------. 1 root root  4 Mar 26 04:45 fs0-fs.pid
srwxrwxr-x. 1 qemu qemu  0 Mar 26 04:45 fs0-fs.sock
-rw-------. 1 root root  4 Mar 26 04:45 fs1-fs.pid
srwxrwxr-x. 1 qemu qemu  0 Mar 26 04:45 fs1-fs.sock
-rw-------. 1 root root  4 Mar 26 04:45 ua-1035e984-8238-46e1-bf56-b546246e1a39-fs.pid
srwxrwxr-x. 1 qemu qemu  0 Mar 26 04:45 ua-1035e984-8238-46e1-bf56-b546246e1a39-fs.sock
The socket file is consistent with the pid file.

Comment 10 errata-xmlrpc 2020-05-05 09:59:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2017


Note You need to log in before you can comment on or make changes to this bug.