Bug 1816642 - Review Request: golang-github-resty - Simple HTTP and REST client library
Summary: Review Request: golang-github-resty - Simple HTTP and REST client library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-24 12:35 UTC by Fabian Affolter
Modified: 2020-04-09 18:18 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-09 14:42:43 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-03-24 12:35:03 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-resty.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-resty-2.2.0-1.fc31.src.rpm

Project URL: https://github.com/go-resty/resty

Description:
Simple HTTP and REST client library for Go.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=42738403

rpmlint output:
$ rpmlint golang-github-resty-2.2.0-1.fc31.src.rpm 
golang-github-resty.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint golang-github-resty-devel-2.2.0-1.fc31.noarch.rpm
golang-github-resty-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/go-resty/resty/.goipath
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-03-27 16:52:50 UTC
 - Don't include this docs:

 .testdata/text-file.txt

 - Add a comment explaining why you disable the tests (Need network for ex)

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Fabian Affolter 2020-03-30 11:53:01 UTC
Thanks for the review.

(In reply to Robert-André Mauchin from comment #1)
>  - Don't include this docs:
> 
>  .testdata/text-file.txt

File removed.

>  - Add a comment explaining why you disable the tests (Need network for ex)

Comment added.

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-resty.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-resty-2.2.0-2.fc31.src.rpm

Comment 3 Gwyn Ciesla 2020-03-30 13:45:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-resty

Comment 4 Fedora Update System 2020-03-31 08:01:16 UTC
FEDORA-2020-68f7debb70 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-68f7debb70

Comment 5 Fedora Update System 2020-03-31 08:26:01 UTC
FEDORA-2020-28b5301501 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-28b5301501

Comment 6 Fedora Update System 2020-04-01 02:14:43 UTC
FEDORA-2020-68f7debb70 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-68f7debb70 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-68f7debb70

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-04-01 03:54:35 UTC
FEDORA-2020-28b5301501 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-28b5301501 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-28b5301501

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-04-09 14:42:43 UTC
FEDORA-2020-68f7debb70 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-04-09 18:18:01 UTC
FEDORA-2020-28b5301501 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.