Bug 1817004 - incorrect grub.cfg generated on Silverblue
Summary: incorrect grub.cfg generated on Silverblue
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: grub2
Version: 33
Hardware: ppc64le
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Javier Martinez Canillas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PPCTracker
TreeView+ depends on / blocked
 
Reported: 2020-03-25 11:45 UTC by Dan Horák
Modified: 2021-06-29 20:10 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-06-29 20:10:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
/boot/loader/grub.cfg (6.62 KB, text/plain)
2020-03-25 11:45 UTC, Dan Horák
no flags Details
/boot/loader/entries/ostree-1-fedora.conf (555 bytes, text/plain)
2020-03-25 11:48 UTC, Dan Horák
no flags Details
grub.cfg from re-running grub2-mkconfig (6.75 KB, text/plain)
2020-03-26 15:43 UTC, Dan Horák
no flags Details
installation logs (327.22 KB, application/gzip)
2020-03-26 15:43 UTC, Dan Horák
no flags Details

Description Dan Horák 2020-03-25 11:45:08 UTC
Created attachment 1673387 [details]
/boot/loader/grub.cfg

Description of problem:
After installing Silverblue (Fedora-Silverblue-ostree-ppc64le-Rawhide-20200324.n.0.iso) on a ppc64le VM the system can't boot failing on some ostree error (Can't find OSTree root). Then I realized
- the boot menu presents 2 options, named the same
- the first/default leads to unbootable system
- the second one boots correctly

The problem is in the generated grub.cfg, see attachment. First boot entry (from 10_linux_bls) has all kernel options stripped, except ostree=. The second one (from 15_ostree) looks complete.

Version-Release number of selected component (if applicable):
grub2-2.04-9.fc32

How reproducible:
100%


Steps to Reproduce:
1. install Silverblue for ppc64le

Actual results:
2 entries in grub menu during, only the 2nd option has all options and allows the system to boot

Expected results:
single boot entry with required options

Comment 1 Dan Horák 2020-03-25 11:48:24 UTC
Created attachment 1673389 [details]
/boot/loader/entries/ostree-1-fedora.conf

Comment 2 Javier Martinez Canillas 2020-03-26 10:23:04 UTC
Hello Dan,

(In reply to Dan Horák from comment #0)
> Created attachment 1673387 [details]
> /boot/loader/grub.cfg
> 
> Description of problem:
> After installing Silverblue
> (Fedora-Silverblue-ostree-ppc64le-Rawhide-20200324.n.0.iso) on a ppc64le VM
> the system can't boot failing on some ostree error (Can't find OSTree root).
> Then I realized
> - the boot menu presents 2 options, named the same
> - the first/default leads to unbootable system
> - the second one boots correctly
> 
> The problem is in the generated grub.cfg, see attachment. First boot entry
> (from 10_linux_bls) has all kernel options stripped, except ostree=. The
> second one (from 15_ostree) looks complete.
> 

Strange, I can't see why the other options could had been stripped... and I'm not able to reproduce it locally. When using the BLS snippet that you attached I get:

menuentry 'Fedora Rawhide.20200313.n.0 (Silverblue) (ostree:0)'  --id= {
         linux /ostree/fedora-c41ea2c94047bf612955c368883e4266bae6cf9198bf43c63b2f10598c6e91a2/vmlinuz-5.6.0-0.rc5.git1.1.fc33.ppc64le rd.lvm.lv=fedora_fedora-ppc/root00 rd.lvm.lv=fedora_fedora-ppc/swap00 rhgb quiet root=/dev/mapper/fedora_fedora--ppc-root00 ostree=/ostree/boot.0/fedora/c41ea2c94047bf612955c368883e4266bae6cf9198bf43c63b2f10598c6e91a2/0
         initrd /ostree/fedora-c41ea2c94047bf612955c368883e4266bae6cf9198bf43c63b2f10598c6e91a2/initramfs-5.6.0-0.rc5.git1.1.fc33.ppc64le.img
}

which is similar to the entry generated by /etc/grub.d/15_ostree that has the correct kernel cmdline options.

Could you please re-run grub2-mkconfig -o /tmp/grub.cfg and check if the generated GRUB config file is correct?

Comment 3 Dan Horák 2020-03-26 15:42:31 UTC
Re-running grub2-mkconfig on the installed system gives a good grub.cfg, all kernel cmdline parameters are present.

Comment 4 Dan Horák 2020-03-26 15:43:18 UTC
Created attachment 1673826 [details]
grub.cfg from re-running grub2-mkconfig

Comment 5 Dan Horák 2020-03-26 15:43:55 UTC
Created attachment 1673827 [details]
installation logs

Comment 6 Dan Horák 2020-03-26 15:45:54 UTC
I forgot to mention, the new grub.cfg still has 2 entries (but they are equivalent now). I wonder if the BLS generator should be skipped if running with ostree support.

Comment 7 Ben Cotton 2020-08-11 13:15:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 8 Fedora Admin user for bugzilla script actions 2021-05-07 00:34:48 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 9 Javier Martinez Canillas 2021-06-17 23:12:31 UTC
Is this issue still present? I believe should be fixed by now.

Comment 10 Dan Horák 2021-06-22 07:43:29 UTC
The issue is not present any more AFAICT, it has been fixed a while ago.

Comment 11 Javier Martinez Canillas 2021-06-29 20:10:31 UTC
(In reply to Dan Horák from comment #10)
> The issue is not present any more AFAICT, it has been fixed a while ago.

Thanks Dan, closing this then.


Note You need to log in before you can comment on or make changes to this bug.