RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1817432 - Make "secure" temp files (by not saving them in /tmp)
Summary: Make "secure" temp files (by not saving them in /tmp)
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: resource-agents
Version: 8.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.3
Assignee: Oyvind Albrigtsen
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 1817439
TreeView+ depends on / blocked
 
Reported: 2020-03-26 10:57 UTC by Oyvind Albrigtsen
Modified: 2023-04-11 14:57 UTC (History)
6 users (show)

Fixed In Version: resource-agents-4.1.1-46.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1817439 (view as bug list)
Environment:
Last Closed: 2020-07-28 07:13:33 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-39909 0 None None None 2023-04-11 14:57:46 UTC

Description Oyvind Albrigtsen 2020-03-26 10:57:51 UTC
Description of problem:
To avoid tmp race conditions, and possibly users or other software changing tmp files in /tmp this patch creates the patches in /run/resource-agents (defined by $HA_RSCTMP during ./configure).

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Setup ClusterMon
2. Check that it's using /run/resource-agents location instead of /tmp for temp files
3.

Actual results:


Expected results:


Additional info:
https://github.com/ClusterLabs/resource-agents/pull/1467

Comment 1 Patrik Hagara 2020-03-26 12:12:30 UTC
The /var/run/resource-agents directory does not need the sticky bit set (no other dir under /var/run has it). This can be fixed in the resource-agents spec file.

The /var/run/resource-agents directory tree should get the "cluster_var_run_t" selinux label instead of default "var_run_t". A new BZ should be filed against selinux-policy.

Additionally, I think the selinux rules for cluster_var_run_t should be trimmed a bit, since as of now they inherit permissions from the var_run_t label, which is quite a handful (and these are only the "allowed to write to file" rules):

> [root@virt-123 ~]# sesearch -t cluster_var_run_t -c file -p write --allow
> allow abrt_dump_oops_t non_security_file_type:file { append create getattr ioctl link lock map open read rename setattr unlink write };
> allow chronyc_t non_security_file_type:file { append getattr ioctl lock open read write };
> allow cluster_t cluster_var_run_t:file { append create getattr ioctl link lock open read rename setattr unlink write };
> allow daemon cluster_var_run_t:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ daemons_enable_cluster_mode ]:True
> allow files_unconfined_type file_type:file { append audit_access create execute execute_no_trans getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto rename setattr swapon unlink write };
> allow ftpd_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ ftpd_full_access ]:True
> allow glusterd_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ gluster_export_all_rw ]:True
> allow kernel_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ nfs_export_all_rw ]:True
> allow mount_t non_security_file_type:file { read write }; [ mount_anyfile ]:True
> allow nmbd_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ samba_export_all_rw ]:True
> allow pegasus_openlmi_logicalfile_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write };
> allow postgresql_t cluster_var_run_t:file { append create getattr ioctl link lock open read rename setattr unlink write };
> allow puppetagent_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ puppetagent_manage_all_files ]:True
> allow rpm_script_t file_type:file { append create getattr ioctl link lock open read relabelfrom relabelto rename setattr unlink write };
> allow rpm_t file_type:file { append create getattr ioctl link lock open read relabelfrom relabelto rename setattr unlink write };
> allow rsync_t non_auth_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ rsync_full_access ]:True
> allow smbd_t non_security_file_type:file { append create getattr ioctl link lock open read rename setattr unlink write }; [ samba_export_all_rw ]:True
> allow sysadm_t non_security_file_type:file { append create getattr ioctl link lock open read relabelfrom relabelto rename setattr unlink write };
> allow system_dbusd_t non_security_file_type:file { read write };
> allow systemd_tmpfiles_t non_auth_file_type:file { append create getattr ioctl link lock open read relabelfrom relabelto rename setattr unlink write };

However, I'm not a selinux expert -- maybe this is fine.

Comment 2 Patrik Hagara 2020-03-26 12:19:34 UTC
qa_ack+, reproducer in description (issues from comment#1 to be dealt with separately in other BZs)


Note You need to log in before you can comment on or make changes to this bug.