Description of problem: When migrationcontroller resource is edited to redefine the configured limits, the new configured limits are ignored. Version-Release number of selected component (if applicable): CAM 1.1.2 OCP 4.2 How reproducible: Always Steps to Reproduce: 1. Install CAM using this limit value in the migration controller mig_namespace_limit: "2" 2. Run a migration of 3 clusters. The migration should be show a Critical Condition preventing the execution. 3. Edit the migrationcontroller limit and use: $ oc edit migrationcontroller migration-controller -n openshift-migration .... mig_namespace_limit: "4" Actual results: After setting the new limit to "4" the migration continues blocked with the critical condition. Expected results: The new limit should be used, and migrations with 3 namespaces should be allowed. Additional info: Whenever we change the limits in migrationcontroller resource, the controller should be redeployed to take the new values. This redeployment is not happening.
Was not happening to me on latest. This condition only appears on the MigPlan resource for me, and reproducing those steps resulted in correct behaviour, it just took appr. 1 min.. Could it be that the operator was failing to reconcile and update controller instance?
Let's double confirm to see if the original issue still existing in the last 1.2 code.
Was able to confirm the issue, and the fix is out there - https://github.com/konveyor/mig-operator/pull/295 Apparently, when the first value in the filters is a single character, the whole join is obsolete, and SHA1 is receiving the same single character no matter what is in the joins. The PR claims to fix it, as cors_origins will never be empty.
Verified using CAM 1.2 stage After editing MigrationController resource, changing mig_namespace_limit, the controller pod was restarted using the new limits.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:2326