Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01322961-ms-studio-karmilla-fonts/ms-studio-karmilla-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01322961-ms-studio-karmilla-fonts/ms-studio-karmilla-fonts-0.16-1.20200329git0019472.fc33.src.rpm Description: Karmilla is an expanded version of Karla, an outstanding grotesque sans serif font family created by Jonathan Pinhorn. Fedora Account System Username: nim
Here is a successfull Koji scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=43838147
Hello Nicolas, please check the issues. Thanks in advance, Hirotaka Wakabayashi Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Upstream's latest version is 0.15 Please set the right version. The package version is 0.16, which is newere than the upstream one. - %{?dist} should never be used in the %changelog entries. "0.16-1.0.20200329git0019472" should be "0.16-1". https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/#_using_dist ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "SIL Open Font License 1.1", "*No copyright* Public domain". 1154 files have unknown license. Detailed output of licensecheck in /home/vagrant/FedoraReview/1818567-ms- studio-karmilla-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [-]: fontpackages-tools, which contains repo-font-audit, is replaced by fonts-rpm-macros. However, it doesn't provide repo-font-audit. [-]: ttname package doesn't exist in fedora3? at least. Rpmlint ------- Checking: ms-studio-karmilla-fonts-0.16-1.20200329git0019472.fc33.noarch.rpm ms-studio-karmilla-fonts-0.16-1.20200329git0019472.fc33.src.rpm ms-studio-karmilla-fonts.noarch: W: incoherent-version-in-changelog 0.16-1.0.20200329git0019472 ['0.16-1.20200329git0019472.fc33', '0.16-1.20200329git0019472'] 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- ms-studio-karmilla-fonts.noarch: W: incoherent-version-in-changelog 0.16-1.0.20200329git0019472 ['0.16-1.20200329git0019472.fc33', '0.16-1.20200329git0019472'] 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/ms-studio/karmilla/archive/0019472c75df40462ef57cd4e26d273d0fa01857/karmilla-0019472c75df40462ef57cd4e26d273d0fa01857.tar.gz : CHECKSUM(SHA256) this package : 45770784ddd68b6c6fad3729a0a55e288ede20cc5512851db179ee92bfb3b3f3 CHECKSUM(SHA256) upstream package : 45770784ddd68b6c6fad3729a0a55e288ede20cc5512851db179ee92bfb3b3f3 Requires -------- ms-studio-karmilla-fonts (rpmlib, GLIBC filtered): config(ms-studio-karmilla-fonts) fontpackages-filesystem Provides -------- ms-studio-karmilla-fonts: config(ms-studio-karmilla-fonts) font(karmilla) metainfo() metainfo(org.fedoraproject.ms-studio-karmilla-fonts.metainfo.xml) ms-studio-karmilla-fonts Generated by fedora-review 0.7.5 (cd5b7df) last change: 2020-03-19 Command line :try-fedora-review -b 1818567 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Perl, C/C++, Ocaml, Python, Java, Haskell, PHP, R, Ruby, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Hi Hirotaka Thank you for the kind review. The last tagged version is 0.15, but the actual packaged state (a later commit) is 0.16. If you open project fontlog, you will see the project version bumping to 0.16 in 2016 > 23 May 2016 (ms-studio) Karmilla v.016 Don’t ask me why the project stopped tagging new versions after 0.15 :(. Anyway, rolling back to 0.15 would deprive Fedora users of all the fixed done in the project since 0.15. There are no new upstream font builds after the packaged commit https://github.com/ms-studio/karmilla/tree/master/dist/version%2015/fonts/ttf ! → Latest commit 0019472 on 11 Dec 2018 (almost 2 years after the fontlog switched version to 0.16) %{dist} is not used in the %changelog, as seen in the rpmlint error I made the mistake of writing 1.0 instead of 1 for release in the changelog entry 0.16-1.0.20200329git0019472 ['0.16-1.20200329git0019472.fc33'] I will remove the needless .0, that will satisfy rpmlint
Hello Nicolas, Sorry for my late reply because of my email filtering problem. > Don’t ask me why the project stopped tagging new versions after 0.15 :(. Anyway, rolling back to 0.15 would deprive Fedora users of all the fixed done in the project since 0.15. Thank you very much for your comments. I understand the reason why you use 0.16. I think the version should be 0.16. > %{dist} is not used in the %changelog, The spec file should be consistent for legibility[1]. I think you should remove the needless "0." or modify "Release:" tag as "1.0". 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility Thanks in advance, Hirotaka Wakabayashi
Hello Nicolas, Please fix the aforementioned issue before import. Package approved. Best, Hirotaka Wakabayashi
Review stalled, resetting ticket status
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.