Spec URL: https://gitlab.com/fedora-mobile/ofono/-/raw/master/ofono.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01280301-ofono/ofono-1.31-3.fc33.src.rpm Description: open source telephony, used by KDE plasma mobile to handle phone calls, sms, etc. Fedora Account System Username: njha This package was orphaned for long enough that it requires a re-review. As always, here's a successful COPR build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1280301/ There's one rpmlint error (ofono.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/ofonod) but I'm not sure if that's significant or how to fix it.
Adding myself to the CC list since I maintain modem-manager-gui and it has an ofono plugin (currently disabled from building). >%description devel >%{summary}. Maybe just write something generic like "This package contains files required to develop applications using oFono"?
Sounds good, updated the description in the specfile. That probably won't affect how it builds but I rebuilt it anyway. https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1324602/
Hello, Is this package being revived because this is required for pulseaudio to get (HSP/HFP) head-set-mode working ? https://freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Bluetooth/#usingbluetoothwhenrunningpulseaudiointhesystemmode If so you are also going to need phonesim. A copr build can be found here: https://copr.fedorainfracloud.org/coprs/nielsenb/oFono-phonesim/packages/ If not... please ignore this message
I need it for KDE Plasma Mobile on the PinePhone, but that needs oFono-phonesim too. I just haven't gotten around to making it. Are you going to submit it (probably as ofono-phonesim instead of just phonesim)?
I managed to package ofono and phonesim localy but but the headset mode still failed to work with the latest pulseaudio and bluetooth on my fedora 31 kde install. I wanted it to work before even considering submitting it. ps that copr repo isn't mine. Rob
- Missing isa in the devel subpackage: Requires: %{name}%{?_isa} = %{version}-%{release} - Not needed BuildRequires: systemd Requires(post): systemd Requires(preun): systemd Requires(postun): systemd use: BuildRequires: systemd-rpm-macros - Error in %changelog, March 30 is a Monday: warning: bogus date in %changelog: Fri Mar 30 2020 Nikhil Jha <hi> - 1.31-1 - Explicitly add a BR against gcc [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: ofono-1.31/configure.ac:31 Patch it with LT_INIT instead and send a patch upstream. (Ref: https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/ofono See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License", "GPL (v2 or later)", "GPL (v2)", "GPL (v2 or later) (with incorrect FSF address)", "Unicode strict GPL (v2)". 203 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ofono/review-ofono/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in ofono [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ofono- devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ofono-1.31-1.fc33.x86_64.rpm ofono-devel-1.31-1.fc33.x86_64.rpm ofono-debuginfo-1.31-1.fc33.x86_64.rpm ofono-debugsource-1.31-1.fc33.x86_64.rpm ofono-1.31-1.fc33.src.rpm ofono.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/ofonod ofono.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/ofono.conf ofono-devel.x86_64: W: no-documentation ofono.src: E: specfile-error warning: bogus date in %changelog: Fri Mar 30 2020 Nikhil Jha <hi> - 1.31-1 5 packages and 0 specfiles checked; 2 errors, 2 warnings.
Thanks & sorry for the late reply, I got busy with school again. - Missing isa in the devel subpackage: Fixed. - Not needed Fixed. - Error in %changelog, March 30 is a Monday: Fixed. - Explicitly add a BR against gcc Fixed. - AutoTools: Obsoleted m4s found Patched, sent patch to upstream mailing list. --- SPEC: https://gitlab.com/fedora-mobile/ofono/-/raw/master/ofono.spec COPR build: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1613145/ Direct link to SRPM: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01613145-ofono/ofono-1.31-1.fc34.src.rpm
Package approved.
Package is available in repos.