Bug 1819019 - ppc64le: ibmvscsi driver missing from supermin appliance
Summary: ppc64le: ibmvscsi driver missing from supermin appliance
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: supermin
Version: 31
Hardware: ppc64le
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-31 00:28 UTC by Gustavo Luiz Duarte
Modified: 2020-04-27 02:43 UTC (History)
3 users (show)

Fixed In Version: supermin-5.2.0-2.fc31 supermin-5.2.0-2.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-19 22:45:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
0001-Fix-IBM-Vitual-SCSI-driver-name.patch (836 bytes, patch)
2020-03-31 00:35 UTC, Gustavo Luiz Duarte
no flags Details | Diff

Description Gustavo Luiz Duarte 2020-03-31 00:28:19 UTC
Description of problem:

Recently the coreos-assembler switched from virtio-scsi to the qemu option -hda, which uses the ibmvscsi driver on ppc64le. That broke the supermin appliance, as seen at https://github.com/coreos/coreos-assembler/pull/1288#issuecomment-605094147

It turns out that the ibmvscsi driver is not being included in the supermin initrd. Supermin is trying to include the driver ibmvscsic.ko, which was renamed to ibmvscsi.ko back in the Linux kernel 3.7. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9965c2f19be470c452357ae4f6304467cdeada55

Comment 1 Gustavo Luiz Duarte 2020-03-31 00:35:18 UTC
Created attachment 1674899 [details]
0001-Fix-IBM-Vitual-SCSI-driver-name.patch

I tested the attached patch on ppc64le and it fixes the supermin appliance with the -hda qemu option.

I don't think supermin is supported on any ppc64le distro running a kernel older than 3.7, so I believe the attached fix should be fine for upstream supermin.

[]'s
Gustavo

Comment 2 Pino Toscano 2020-03-31 06:46:55 UTC
Hi Gustavo Luiz,

(In reply to Gustavo Luiz Duarte from comment #1)
> Created attachment 1674899 [details]
> 0001-Fix-IBM-Vitual-SCSI-driver-name.patch
> 
> I tested the attached patch on ppc64le and it fixes the supermin appliance
> with the -hda qemu option.

At least to a non-ppc64le developer the explanation seems correct.
Can you please send the patch to the libguestfs mailinst list, as described here:
http://libguestfs.org/guestfs-hacking.1.html#submitting-patches
(use a "supermin" prefix for your patch)

> I don't think supermin is supported on any ppc64le distro running a kernel
> older than 3.7, so I believe the attached fix should be fine for upstream
> supermin.

I don't see any reason to drop support for it, though.

Thanks!

Comment 3 Richard W.M. Jones 2020-03-31 09:48:49 UTC
Note that you don't have to subscribe.  You can just email the patch to libguestfs

Comment 4 Gustavo Luiz Duarte 2020-03-31 20:10:58 UTC
(In reply to Pino Toscano from comment #2)
> Hi Gustavo Luiz,
> 
> (In reply to Gustavo Luiz Duarte from comment #1)
> > Created attachment 1674899 [details]
> > 0001-Fix-IBM-Vitual-SCSI-driver-name.patch
> > 
> > I tested the attached patch on ppc64le and it fixes the supermin appliance
> > with the -hda qemu option.
> 
> At least to a non-ppc64le developer the explanation seems correct.
> Can you please send the patch to the libguestfs mailinst list, as described
> here:
> http://libguestfs.org/guestfs-hacking.1.html#submitting-patches
> (use a "supermin" prefix for your patch)


Sure, I will send the patch in a moment.


> 
> > I don't think supermin is supported on any ppc64le distro running a kernel
> > older than 3.7, so I believe the attached fix should be fine for upstream
> > supermin.
> 
> I don't see any reason to drop support for it, though.


OK. Then I will change the patch and keep both ibmvscsic.ko and ibmvscsi.ko patterns to make sure we keep support for kernels older than 3.7.


> 
> Thanks!

Comment 5 Pino Toscano 2020-04-03 10:19:27 UTC
The patch was sent upstream:
https://www.redhat.com/archives/libguestfs/2020-April/msg00000.html
and accepted and merged:
https://github.com/libguestfs/supermin/commit/3f831d30d87658d362e9b4f25fa569937fa1c23f

Since this is a Fedora bug, I'll leave it open until the fix reaches the packaged version.

Comment 6 Fedora Update System 2020-04-03 11:23:55 UTC
FEDORA-2020-76a2ddcc45 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-76a2ddcc45

Comment 7 Fedora Update System 2020-04-03 11:30:15 UTC
FEDORA-2020-0c5efb4028 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0c5efb4028

Comment 8 Fedora Update System 2020-04-04 02:41:10 UTC
FEDORA-2020-0c5efb4028 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-0c5efb4028`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0c5efb4028

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-04-04 06:16:57 UTC
FEDORA-2020-76a2ddcc45 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-76a2ddcc45`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-76a2ddcc45

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-04-19 22:45:16 UTC
FEDORA-2020-0c5efb4028 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-04-27 02:43:27 UTC
FEDORA-2020-76a2ddcc45 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.