Bug 1819227 - WMCO is unnecessarily watching pods
Summary: WMCO is unnecessarily watching pods
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Windows Containers
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.5.0
Assignee: vhire@redhat.com
QA Contact: gaoshang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-31 13:59 UTC by Sebastian Soto
Modified: 2020-07-13 17:24 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:24:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift windows-machine-config-operator pull 52 0 None closed Bug 1819227: [wmco] Remove unnecessary watching of Pods 2020-10-30 02:01:08 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:24:31 UTC

Description Sebastian Soto 2020-03-31 13:59:11 UTC
Description of problem:
The WMCO is watching pods when it does not need to
https://github.com/openshift/windows-machine-config-operator/blob/master/pkg/controller/windowsmachineconfig/windowsmachineconfig_controller.go#L76

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
Run the operator

Actual results:
WMCO is watching pods

Expected results:
WMCO does not watch pods. WMCO works without having RBAC permissions to watch pods.

Additional info:

Comment 3 gaoshang 2020-05-20 09:35:17 UTC
QE verification is blocked by Bug 1837936, will verify it when problem resolved,thanks.

Comment 4 gaoshang 2020-05-28 17:58:39 UTC
QE testing passed

Version:
windows-machine-config-operator git commit: 8edef3c68c34c7c558cf3f039c9eb8706f429d7c

Steps:

After removed watch pods and RBAC permissions to watch pods, wmco works as expected

Comment 6 errata-xmlrpc 2020-07-13 17:24:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.