Spec Url: http://guava.farsiweb.info/~roozbeh/charis-fonts.spec SRPM Url: http://guava.farsiweb.info/~roozbeh/charis-fonts-4.0.02-1.src.rpm Description: Charis SIL provides glyphs for a wide range of Latin and Cyrillic characters. Charis is similar to Bitstream Charter, one of the first fonts designed specifically for laser printers. It is highly readable and holds up well in less-than-ideal reproduction environments. It also has a full set of styles - regular, italic, bold, bold italic - and so is more useful in general publishing than Doulos SIL. Charis is a serif proportionally spaced font optimized for readability in long printed documents.
This is a nice, clean package; you should consider submitting a specfile template for fonts. Upstream's download system is annoying, but that's not your fault and you at least provided instructions for getting the source. rpmlint says: W: charis-fonts invalid-license SIL Open Font License W: charis-fonts wrong-file-end-of-line-encoding /usr/share/doc/charis-fonts-4.0.02/CharisSIL4FontDocumentation.pdf The license is acceptable; it's probably worth opening a bug against rpmlint to get it added. The second warning is just rpmlint being dumb; there's no point in paying attention to line endings in a PDF file. Anyway: rpmlint output is fine. The package meets the naming and packaging guidelines. The specfile is properly named and follows rather exactly that of a previously accepted package. The source file matches upstream. The license is appropriate and included as %doc. Approved.
Thanks a lot for the review. Imported and built.
Just a reminder that fonts.cache-1 file ghosting is not needed for FC5. See http://www.redhat.com/archives/fedora-extras-list/2006-January/msg00918.html
OTOH, ghosting fonts.cache-1 doesn't hurt anything either, and maintains compability with older releases.