Bug 1820009
| Summary: | Improve the performance of nmstate when creating 300+ bridge with 1 VLAN each. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Gris Ge <fge> | ||||||
| Component: | nmstate | Assignee: | Gris Ge <fge> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Mingyu Shi <mshi> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 8.2 | CC: | dholler, ferferna, jiji, jishi, network-qe, till | ||||||
| Target Milestone: | rc | Flags: | pm-rhel:
mirror+
|
||||||
| Target Release: | 8.3 | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | nmstate-0.3.2-6.el8 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2020-11-04 03:08:54 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Gris Ge
2020-04-02 03:58:16 UTC
Created attachment 1675625 [details]
terminal log
Please note that most of the computing time is currently consumed by firewalld, ovs-vswtichd and NetworkManager.
On RHEL 8.2.0, adding
the first 100 vlans and bridges takes around 30 seconds,
the next 100 ones takes around 50 seconds,
the next 100 ones takes around 80 seconds,
the next 100 ones takes around 120 seconds, and
the next 100 ones takes around 170 seconds.
Would be helpful, if nmstate could provide responsetimes < 150 seconds to modify up to 1000 vlan-bridge combinations.
Hi Dominik, I have posted a patch to upstream which improved the performance: * Create 500 VLANs + 500 bridges over each in a single transaction, nmstate takes 346 seconds. * Create 300 VLANs + 300 bridges over each in a single transaction, nmstate takes 114 seconds. * Create 100 VLANs + 100 bridges over each in a single transaction, nmstate takes 15 seconds. OS details: RHEL 8.2 + NetworkManager master branch(1.23.2) + firewalld and ovs daemons running. You may try the rpm via command `dnf copr enable packit/nmstate-nmstate-1016`. Base on my test and repeat trying, nmstate can only support up to 1000 interfaces in a single desire state unless NetworkManager make big performance improvements. Same VM as in comment #1, with new software as described in comment #2 [1]: the first 100 vlans and bridges takes 0m13.970s the next 100 ones takes around 0m30.095s the next 100 ones takes around 0m39.632s the next 100 ones takes around 0m52.081s the next 100 ones takes around 1m9.734s the next 100 ones takes around 1m20.677s the next 100 ones takes around 1m33.498s the next 100 ones takes around 1m41.105s the next 100 ones fails. The means up to 800 networks works in an amazing time, great work Gris! Let's check if we can agree that this is what we want to keep in the long run. [1] nmstate-0.3.0-0.20200408115626576019.el8.noarch NetworkManager-1.23.2-25381.9a74d2e023.el8.x86_64 >
> The means up to 800 networks works in an amazing time, great work Gris!
> Let's check if we can agree that this is what we want to keep in the long
> run.
>
The 500 networks(500 VLANs and 500 bridge over each) seems a reasonable amount.
If RHV agree on that, I can make that tested in our CI and officially documented.
(In reply to Gris Ge from comment #4) > > > > The means up to 800 networks works in an amazing time, great work Gris! > > Let's check if we can agree that this is what we want to keep in the long > > run. > > > > The 500 networks(500 VLANs and 500 bridge over each) seems a reasonable > amount. > If RHV agree on that, I can make that tested in our CI and officially > documented. Thanks, RHV agrees on 300 networks (300 VLANs and 300 bridge over each). Verified with versions: nmstate-0.3.3-2.el8.noarch NetworkManager-1.26.0-2.el8.x86_64 DISTRO=RHEL-8.3.0-20200721.n.0 Linux dell-r330-15.gsslab.brq.redhat.com 4.18.0-226.el8.x86_64 #1 SMP Wed Jul 15 07:40:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux To create with 300 ones, it took real 0m52.557s user 0m11.554s sys 0m1.124s On nmstate-0.2.6-6.el8.noarch, it took: real 2m1.540s user 0m21.550s sys 0m2.760s Created attachment 1701856 [details]
verified.log
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:4696 |