Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-malfunkt-iprange-devel-0.9.0-1.fc33.noarch.rpm
          golang-github-malfunkt-iprange-0.9.0-1.fc33.src.rpm
golang-github-malfunkt-iprange-devel.noarch: W: spelling-error Summary(en_US) nmap -> nap, map, neap
golang-github-malfunkt-iprange-devel.noarch: W: spelling-error %description -l en_US nmap -> nap, map, neap
golang-github-malfunkt-iprange-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/malfunkt/iprange/.goipath
golang-github-malfunkt-iprange.src: W: spelling-error Summary(en_US) nmap -> nap, map, neap
golang-github-malfunkt-iprange.src: W: spelling-error %description -l en_US nmap -> nap, map, neap
golang-github-malfunkt-iprange.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
golang-github-malfunkt-iprange-devel.noarch: W: spelling-error Summary(en_US) nmap -> nap, map, neap
golang-github-malfunkt-iprange-devel.noarch: W: spelling-error %description -l en_US nmap -> nap, map, neap
golang-github-malfunkt-iprange-devel.noarch: W: invalid-url URL: https://github.com/malfunkt/iprange <urlopen error [Errno -2] Name or service not known>
golang-github-malfunkt-iprange-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/malfunkt/iprange/.goipath
1 packages and 0 specfiles checked; 0 errors, 4 warnings.



Source checksums
----------------
https://github.com/malfunkt/iprange/archive/v0.9.0/iprange-0.9.0.tar.gz :
  CHECKSUM(SHA256) this package     : e5ef7f67f06bb3a6d9221a6d30f37e3e808b94a42398a731c0e90b91daa1aa99
  CHECKSUM(SHA256) upstream package : e5ef7f67f06bb3a6d9221a6d30f37e3e808b94a42398a731c0e90b91daa1aa99


Requires
--------
golang-github-malfunkt-iprange-devel (rpmlib, GLIBC filtered):
    go-filesystem
    golang(github.com/pkg/errors)



Provides
--------
golang-github-malfunkt-iprange-devel:
    golang(github.com/malfunkt/iprange)
    golang-github-malfunkt-iprange-devel
    golang-ipath(github.com/malfunkt/iprange)

Thanks for the review.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-malfunkt-iprange

FEDORA-2020-425abec16a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-425abec16a

FEDORA-2020-231e9aa60b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-231e9aa60b

FEDORA-2020-425abec16a has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-425abec16a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-425abec16a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-231e9aa60b has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-231e9aa60b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-231e9aa60b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-425abec16a has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2020-231e9aa60b has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.