Bug 1820896 - Please branch rubygem-asciidoctor for EL 8
Summary: Please branch rubygem-asciidoctor for EL 8
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: rubygem-asciidoctor
Version: epel8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott K Logan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1849446 2065935 (view as bug list)
Depends On:
Blocks: 1859390
TreeView+ depends on / blocked
 
Reported: 2020-04-04 14:06 UTC by Richard Shaw
Modified: 2022-05-18 02:56 UTC (History)
11 users (show)

Fixed In Version: rubygem-asciidoctor-2.0.15-3.el8
Clone Of:
Environment:
Last Closed: 2022-05-18 02:56:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Pagure releng/fedora-scm-requests issue 43637 0 None None None 2022-04-13 00:52:47 UTC

Description Richard Shaw 2020-04-04 14:06:55 UTC
Please support an EL 8 branch as it is needed for document generation.

Comment 1 Richard Shaw 2020-04-04 15:33:44 UTC
I tried a COPR build and note the following unmet dependencies:

DEBUG util.py:621:  No matching package to install: 'rubygem(coderay)'
DEBUG util.py:621:  No matching package to install: 'rubygem(erubis)'
DEBUG util.py:621:  No matching package to install: 'rubygem(haml)'
DEBUG util.py:621:  No matching package to install: 'rubygem(nokogiri)'
DEBUG util.py:621:  No matching package to install: 'rubygem(rouge)'
DEBUG util.py:621:  No matching package to install: 'rubygem(slim)'
DEBUG util.py:621:  No matching package to install: 'rubygem(tilt)'

Comment 2 Todd Zullinger 2020-04-04 16:41:09 UTC
It would definitely be nice to get this into el8, but as you note, there are a number of deps which need to make it there first.  I'm hoping that the maintainers of those deps (or others who really want to see asciidoctor in el8) will find the time to get them into el8 eventually.  I don't feel particularly competent to branch and maintain those (nor motivated to be a good caretaker of them), even if there were enough hours in the day. :)

Comment 3 Germano Massullo 2020-07-21 21:42:13 UTC
*** Bug 1849446 has been marked as a duplicate of this bug. ***

Comment 4 Scott K Logan 2022-02-14 21:33:38 UTC
It appears that the conditionals added to the rawhide branch by Neal a few weeks ago conditionalize the missing dependencies, and the rawhide branch of this package now builds successfully against EPEL 8: https://koji.fedoraproject.org/koji/taskinfo?taskID=82823899

Comment 5 Scott K Logan 2022-04-11 19:15:37 UTC
Hi Dan, is there anything I can do to help move this along? If maintenance and/or testing is a concern, please consider adding me (cottsay) as an EPEL-only co-maintainer of this package.

Comment 6 Dan Allen 2022-04-11 19:50:48 UTC
Since there's no one else named Dan on this thread, I'm going to assume you're referring to me. If not, please disregard. I don't maintain this package for EL, so there's nothing I can do to move it along one way or another. However, if you have any question about Asciidoctor itself or how to work with the code, please don't hesitate to contact me. I'm always happy to answer such questions.

Comment 7 Todd Zullinger 2022-04-11 23:11:27 UTC
Scott, thanks for the offer!  I've added you as a committer.  I think that should give you the ability to make an epel8 branch request and push an update. I didn't restrict that to only the epel8 branch, since the branches are generally merged down from rawhide, so if changes are needed for epel8 (or in most any other branch, we should start them in rawhide and let them percolate down).  Let me know if you don't want that much access. :)

AFAIK, the package has "built" for epel8 for some time, since 1f2c7cb (Do not run tests for any %{rhel} distros., 2021-01-21).  It's a shame to not be able to run the tests, but if we keep the spec file shared across fedora and epel branches, I guess that provides some level of testing and confidence -- with "some" being the operative word.

Many of the tests _should_ be able to run on epel9 (and perhaps epel8), but that does require some additional conditionals or treating each branch separately, as Vít noted in https://src.fedoraproject.org/rpms/rubygem-asciidoctor/pull-request/6#comment-77418.  Personally, I tend to prefer a few conditionals in an otherwise shared spec file than managing each branch separately at this time and for this package.  It's not that git's branching isn't wonderful (it is!); it's that it doesn't fit well with how spec files are maintained.  Some of that will improve as the release and changelog can be migrated out of the spec file, but that's not suitable for all of the epel branches AFAIK.  But if there are more active maintainers who want to keep asciidoctor fed and watered and do so with each branch separate, I'm happy to not consume it for the git build process. ;)

The epel-packagers-sig group is a collaborator on the package.  I think that's how it was branched for epel9.  It might be nice if they handled epel8 as well. Dan is listed as the bugzilla assignee on both Fedora and EPEL branches in Pagure.  It seems like we ought to change that for EPEL, as Dan indicated above "I don't maintain this package for EL."

Lastly, I suspect many of us are interested in asciidocter by way of another package (git, for me).  That can keep it from getting the care it needs as so long as it works to build the docs we need, it's out of sight and out of mind.  So the more help, the better.

I will say that upstream is awesome and very responsive to the few issues I've had; Dan in particular, as well the other folks in the Ascidoctor project as well.

Comment 8 Scott K Logan 2022-04-13 00:52:48 UTC
Thanks Dan and Todd.

> ... if changes are needed for epel8 ... we should start them in rawhide and let them percolate down

Noted, thanks.

> I tend to prefer a few conditionals in an otherwise shared spec file than managing each branch separately at this time and for this package.

I have similar preferences!

> I will say that upstream is awesome and very responsive to the few issues I've had

Great to hear, thank you.

Comment 9 John Thacker 2022-04-23 12:47:48 UTC
*** Bug 2065935 has been marked as a duplicate of this bug. ***

Comment 10 John Thacker 2022-04-23 12:49:47 UTC
rubygem-asciidoctor is needed to build Wireshark as of version 3.6.

Comment 11 Fedora Update System 2022-05-09 18:06:10 UTC
FEDORA-EPEL-2022-660ef2e31c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-660ef2e31c

Comment 12 Fedora Update System 2022-05-10 02:26:31 UTC
FEDORA-EPEL-2022-660ef2e31c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-660ef2e31c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-05-18 02:56:50 UTC
FEDORA-EPEL-2022-660ef2e31c has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.