Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-casbin.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-casbin-2.2.2-1.fc31.src.rpm Project URL: https://github.com/casbin/casbin Description: An authorization library that supports access control models like ACL, RBAC, ABAC in Golang. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43068293 rpmlint output: $ rpmlint golang-github-casbin-* golang-github-casbin.src: W: spelling-error Summary(en_US) forACL -> fora Cl, fora-cl, oracle golang-github-casbin.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint golang-github-casbin-devel-2.2.2-1.fc31.noarch.rpm golang-github-casbin-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/casbin/casbin/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-casbin-2.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-casbin-2-2.2.2-1.fc31.src.rpm
Hello Fabian, Could you tell me why "golang-github-casbin-2" is needed? You may know this already, but Golang source packages MUST be named after their main import path and golang-github-casbin repository already exists. https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_naming https://src.fedoraproject.org/rpms/golang-github-casbin I think golang-github-casbin-2 should exist if golang-github-casbin have already had EPEL branches and golang-github-casbin's update would have breaken its API because EPEL packages must be stable and they must maintain backwards compatibility. Thanks in advance, Hirotaka Wakabayashi
(In reply to Hirotaka Wakabayashi from comment #2) > Could you tell me why "golang-github-casbin-2" is needed? According to the changelog of the upstream project, introduced the 2.x release breaking changes [1]. With golang-github-casbin-2 it can be avoided that existing thing break and project which are not ported could stay with 1.x > You may know this already, but Golang source packages MUST be named after > their main import path and golang-github-casbin repository already exists. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_naming > https://src.fedoraproject.org/rpms/golang-github-casbin Yes, golang-github-casbin exists and ships the 1.x release stream. Upstream published 1.9.1 approx. a year ago. So far there are no bugfix releases for 1.x after 2.x was released. [1] https://github.com/casbin/casbin/releases/tag/v2.0.0
Hello Fabian, Thank you for your comments. PacKage approved. Please update the version before import. I have reviewed v2.2.2 as well as v2.6.1 by changing the version in the spec file in my local environment. I could understand that the ipath of this package is different from the golang-github-casbin's one so that this package will never conflict with golang-github-casbin. I'm sorry for misunderstanding. Best, Hirotaka Wakabayashi Package Review(v2.2.2) ====================== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-casbin-2-devel-2.2.2-1.fc33.noarch.rpm golang-github-casbin-2-2.2.2-1.fc33.src.rpm golang-github-casbin-2-devel.noarch: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/casbin/casbin/v2/.goipath golang-github-casbin-2.src: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- golang-github-casbin-2-devel.noarch: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/casbin/casbin/v2/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/casbin/casbin/archive/v2.2.2/casbin-2.2.2.tar.gz : CHECKSUM(SHA256) this package : e97e33df4e0ebc821cbdd3e80176d63302fd95d6d19e7458f7c055c1a76a5851 CHECKSUM(SHA256) upstream package : e97e33df4e0ebc821cbdd3e80176d63302fd95d6d19e7458f7c055c1a76a5851 Requires -------- golang-github-casbin-2-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/Knetic/govaluate) Provides -------- golang-github-casbin-2-devel: golang(github.com/casbin/casbin/v2) golang(github.com/casbin/casbin/v2/config) golang(github.com/casbin/casbin/v2/effect) golang(github.com/casbin/casbin/v2/errors) golang(github.com/casbin/casbin/v2/log) golang(github.com/casbin/casbin/v2/model) golang(github.com/casbin/casbin/v2/persist) golang(github.com/casbin/casbin/v2/persist/file-adapter) golang(github.com/casbin/casbin/v2/rbac) golang(github.com/casbin/casbin/v2/rbac/default-role-manager) golang(github.com/casbin/casbin/v2/util) golang-github-casbin-2-devel golang-ipath(github.com/casbin/casbin/v2) Generated by fedora-review 0.7.5 (68531f4) last change: 2020-05-31 Command line :try-fedora-review -b 1821450 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ruby, Haskell, Ocaml, Java, fonts, Perl, PHP, R, Python, SugarActivity, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Package Review(v2.6.1) ====================== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: golang-github-casbin-2-devel-2.6.1-1.fc33.noarch.rpm golang-github-casbin-2-2.6.1-1.fc33.src.rpm golang-github-casbin-2-devel.noarch: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/casbin/casbin/v2/.goipath golang-github-casbin-2.src: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- golang-github-casbin-2-devel.noarch: W: invalid-url URL: https://github.com/casbin/casbin/v2 HTTP Error 404: Not Found golang-github-casbin-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/casbin/casbin/v2/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/casbin/casbin/archive/v2.6.1/casbin-2.6.1.tar.gz : CHECKSUM(SHA256) this package : 3d6f8d50a40d4de41ec9cd9165d29004c7dafcbf32f24b4c60bba3b2f40917ef CHECKSUM(SHA256) upstream package : 3d6f8d50a40d4de41ec9cd9165d29004c7dafcbf32f24b4c60bba3b2f40917ef Requires -------- golang-github-casbin-2-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/Knetic/govaluate) Provides -------- golang-github-casbin-2-devel: golang(github.com/casbin/casbin/v2) golang(github.com/casbin/casbin/v2/config) golang(github.com/casbin/casbin/v2/effect) golang(github.com/casbin/casbin/v2/errors) golang(github.com/casbin/casbin/v2/log) golang(github.com/casbin/casbin/v2/model) golang(github.com/casbin/casbin/v2/persist) golang(github.com/casbin/casbin/v2/persist/file-adapter) golang(github.com/casbin/casbin/v2/rbac) golang(github.com/casbin/casbin/v2/rbac/default-role-manager) golang(github.com/casbin/casbin/v2/util) golang-github-casbin-2-devel golang-ipath(github.com/casbin/casbin/v2) Generated by fedora-review 0.7.5 (68531f4) last change: 2020-05-31 Command line :try-fedora-review --rpm-spec -n /home/vagrant/rpmbuild/SRPMS/golang-github-casbin-2-2.6.1-1.fc33.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, Perl, Haskell, fonts, Ocaml, Java, SugarActivity, PHP, C/C++, R, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review. In the meantime upstream is already at 2.6.12.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-casbin-2