RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1821560 - viostor driver doesn't return correct serial number length.
Summary: viostor driver doesn't return correct serial number length.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: virtio-win
Version: 8.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Vadim Rozenfeld
QA Contact: menli@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-07 04:56 UTC by Vadim Rozenfeld
Modified: 2020-07-21 15:33 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-21 15:32:52 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:3055 0 None None None 2020-07-21 15:33:27 UTC

Description Vadim Rozenfeld 2020-04-07 04:56:59 UTC 
Description of problem:
viostor driver doesn't correct serial number length.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. run Windows 10 VM with -device virtio-blk-pci,...,serial=xru01

2. download and install sg_utils for Windowsfrom http://sg.danny.cz/sg/p/sg3_utils-1.37exe.zip

3.run C:\sg3_utils>sg_vpd.exe -v --hex --page=0x80 d:

Actual results:

Unit serial number VPD page:
    inquiry cdb: 12 01 80 00 fc 00
    inquiry: pass-through requested 252 bytes but got 24 bytes
 00     00 80 00 14 78 72 75 30  31 00 00 00 00 00 00 00    ....xru01.......
 10     00 00 00 00 00 00 00 00                             ........



Expected results:
Unit serial number VPD page:
    inquiry cdb: 12 01 80 00 fc 00
    inquiry: pass-through requested 252 bytes but got 9 bytes
 00     00 80 00 05 78 72 75 30  31                         ....xru01


Additional info:
Comment 1 menli@redhat.com 2020-04-07 06:55:47 UTC 
Hi Vadim,
we use command "wmic diskdrive get SerialNumber" to check serial number in our regular testing. I wonder whether this bug can lead some bad effect and do we need to add it to our regular testing?


Thanks
Menghuan
Comment 2 Vadim Rozenfeld 2020-04-07 08:23:54 UTC 
(In reply to menli from comment #1)
> Hi Vadim,
> we use command "wmic diskdrive get SerialNumber" to check serial number in
> our regular testing. I wonder whether this bug can lead some bad effect and
> do we need to add it to our regular testing?
> 
> 
> Thanks
> Menghuan

Hi Menghuan,

"wmic diskdrive get SerialNumber" is completely fine for the most of the cases.
The problem is that viostor returns serial number (VPD page 0x80) as ASCII string
that is null-terminated , and most application will rely on that. But in addition 
to that miniport driver also reports the serial name string length, that can be 
just incorrect. So, if we want to see that viostor reports the correct serial name
string "wmic diskdrive get SerialNumber" can do it. However, if we want to see that all
parameters retuned by inquiring VPD page 0v80 are fine, then "sg_vpd.exe -v --hex --page=0x80" 
is the tool to check it.

Best,
Vadim.
Comment 3 menli@redhat.com 2020-04-07 08:46:21 UTC 
(In reply to Vadim Rozenfeld from comment #2)
> (In reply to menli from comment #1)
> > Hi Vadim,
> > we use command "wmic diskdrive get SerialNumber" to check serial number in
> > our regular testing. I wonder whether this bug can lead some bad effect and
> > do we need to add it to our regular testing?
> > 
> > 
> > Thanks
> > Menghuan
> 
> Hi Menghuan,
> 
> "wmic diskdrive get SerialNumber" is completely fine for the most of the
> cases.
> The problem is that viostor returns serial number (VPD page 0x80) as ASCII
> string
> that is null-terminated , and most application will rely on that. But in
> addition 
> to that miniport driver also reports the serial name string length, that can
> be 
> just incorrect. So, if we want to see that viostor reports the correct
> serial name
> string "wmic diskdrive get SerialNumber" can do it. However, if we want to
> see that all
> parameters retuned by inquiring VPD page 0v80 are fine, then "sg_vpd.exe -v
> --hex --page=0x80" 
> is the tool to check it.
> 
> Best,
> Vadim.


Hi Vadim,

Got it,much thanks~

Thanks
Menghuan
Comment 4 menli@redhat.com 2020-04-26 07:43:55 UTC 
verified the issue fixed  in build virtio-win-prewhql-0.1-181.iso.

Hi Vadim,
please  modify the bug status to on_qa first,so I can change it verified  status later,thanks.

Thanks

Menghuan
Comment 8 errata-xmlrpc 2020-07-21 15:32:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3055
Note You need to log in before you can comment on or make changes to this bug.