Bug 1822210 - Review Request: golang-gopkg-olivere-elastic-7 - Elasticsearch 7 client for Go
Summary: Review Request: golang-gopkg-olivere-elastic-7 - Elasticsearch 7 client for Go
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AwaitingSubmitter
Depends On: 1821922
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2020-04-08 13:55 UTC by Fabian Affolter
Modified: 2021-12-03 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-12-03 00:45:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Fabian Affolter 2020-04-08 13:55:05 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-7.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-7-7.0.13-1.fc31.src.rpm

Project URL: https://github.com/olivere/elastic

Description:
Elasticsearch 7 client for Go.

Koji scratch build:
fails due to missing dependency
rpmlint output:
$ rpmlint golang-github-olivere-elastic-7-7.0.13-1.fc31.src.rpm 
golang-github-olivere-elastic-7.src: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-7.src: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-7.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint golang-github-olivere-elastic-7-devel-7.0.13-1.fc31.noarch.rpm 
golang-github-olivere-elastic-7-devel.noarch: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-7-devel.noarch: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-7-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/olivere/elastic/v7/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-06-20 21:15:19 UTC
SPEC and bug name should be named golang-gopkg-olivere-elastic-7. This is the name derived from the go import path.

The import path should be: gopkg.in/olivere/elastic.v7 (a dot, not a slash)

Package is not installable:

DEBUG util.py:621:  Error: 
DEBUG util.py:621:   Problem: conflicting requests
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7/aws) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7/aws/v4) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7/config) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7/trace/opentracing) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch
DEBUG util.py:621:    - nothing provides golang(github.com/olivere/elastic/v7/uritemplates) needed by golang-gopkg-olivere-elastic-7-devel-7.0.13-1.fc33.noarch

Probably need to do some replacement of import path to work around the module stuff (v7):

sed -i "s|github.com/olivere/elastic/v7|gopkg.in/olivere/elastic.v7|" $(find . -type f -iname "*.go")

Comment 2 Package Review 2021-11-02 00:45:21 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Package Review 2021-12-03 00:45:25 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.