Description of problem:
local-storage-local-diskmaker and local-storage-local-provisioner daemonsets do not upgrade after the CSV is upgraded to a new version
Version-Release number of selected component (if applicable):
upgrade from 4.3.10 to 4.4.0-0.nightly-2020-04-07-130324
Steps to Reproduce:
1. Before OCP upgrade, install the local storage operator from channel 4.3
2. After the OCP upgraded to 4.4.0-0.nightly-2020-04-07-130324, update the local storage operator subscription's channel to 4.4
3. check the local storage operator
csv is upgraded to the 4.4 version, but the local-storage-local-diskmaker and local-storage-local-provisioner daemonsets do not upgrade.
local-storage-local-diskmaker and local-storage-local-provisioner daemonsets upgrade to the 4.4 too.
Node Log (of failed PODs):
StorageClass Dump (if StorageClass used by PV/PVC):
$ oc get csv -n local-storage|grep local-storage
local-storage-operator.4.4.0-202004040654 Local Storage 4.4.0-202004040654 local-storage-operator.4.3.10-202003311428 Succeeded
$ oc get pod -n local-storage
NAME READY STATUS RESTARTS AGE
hello-openshift-1-jm2vb 1/1 Running 0 155m
local-storage-local-diskmaker-99kj6 1/1 Running 0 3h57m
local-storage-local-diskmaker-gdmsq 1/1 Running 0 3h57m
local-storage-local-diskmaker-nwrpf 1/1 Running 0 3h57m
local-storage-local-diskmaker-xqzbt 1/1 Running 0 3h57m
local-storage-local-provisioner-6bztx 1/1 Running 0 3h57m
local-storage-local-provisioner-985p7 1/1 Running 0 3h57m
local-storage-local-provisioner-fftx7 1/1 Running 0 3h57m
local-storage-local-provisioner-vv2cf 1/1 Running 0 3h57m
local-storage-operator-6c64fff467-97jrg 1/1 Running 0 152m
$ oc get pod local-storage-operator-6c64fff467-97jrg -n local-storage -oyaml|grep "image:"
$ cat manifests/4.4/local-storage-operator.v4.4.0.clusterserviceversion.yaml |grep diskmaker
$ oc get ds local-storage-local-diskmaker -n local-storage -oyaml|grep image
This issue is because the ConfigMaps for the diskmaker and provisioner are not modified when the LSO is updated. They currently are only modified when the LocalVolume resource changes, which does not occur during an operator update.
I've submitted a PR  which includes the controller version in these ConfigMaps, thereby ensuring that they will be redeployed whenever the Operator is updated.
Verified with: local-storage-operator.4.5.0-202005221637
$ oc get csv -n local-storage
NAME DISPLAY VERSION REPLACES PHASE
local-storage-operator.4.5.0-202005221637 Local Storage 4.5.0-202005221637 local-storage-operator.4.3.22-202005201238 Succeeded
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.