Bug 1822214 - Review Request: golang-gopkg-olivere-elastic-5 - Elasticsearch 5 client for Go
Summary: Review Request: golang-gopkg-olivere-elastic-5 - Elasticsearch 5 client for Go
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1821922
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-08 13:59 UTC by Fabian Affolter
Modified: 2020-08-22 19:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-22 19:30:11 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-04-08 13:59:09 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-5.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-olivere-elastic-5-5.0.84-1.fc31.src.rpm

Project URL: https://github.com/olivere/elastic

Description:
Elasticsearch 5 client for Go.

Koji scratch build:
fails due to missing dependency

rpmlint output:
$ rpmlint golang-github-olivere-elastic-5-5.0.84-1.fc31.src.rpm 
golang-github-olivere-elastic-5.src: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-5.src: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-5.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint golang-github-olivere-elastic-5-devel-5.0.84-1.fc31.noarch.rpm 
golang-github-olivere-elastic-5-devel.noarch: W: spelling-error Summary(en_US) Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-5-devel.noarch: W: spelling-error %description -l en_US Elasticsearch -> Elastic search, Elastic-search, Elasticated
golang-github-olivere-elastic-5-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/olivere/elastic.v5/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-06-21 13:56:22 UTC
SPEC and bug name should be named golang-gopkg-olivere-elastic-5. This is the name derived from the go import path.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix name of the SPEC and bug before requesting the repo.

Comment 2 Gwyn Ciesla 2020-07-03 13:32:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-olivere-elastic-5

Comment 3 Fabian Affolter 2020-08-22 19:30:11 UTC
Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.