Bug 182267 - drop static libs, cleanup xmms-config --libs output
Summary: drop static libs, cleanup xmms-config --libs output
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xmms
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Saou
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-02-21 15:27 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-09 10:01:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
xmms.spec.patch (1.67 KB, patch)
2006-02-21 15:27 UTC, Rex Dieter
no flags Details | Diff
xmms-1.2.10-extra_libs.patch (439 bytes, patch)
2006-02-21 15:28 UTC, Rex Dieter
no flags Details | Diff

Description Rex Dieter 2006-02-21 15:27:36 UTC
Subject says it all

Comment 1 Rex Dieter 2006-02-21 15:27:37 UTC
Created attachment 124957 [details]
xmms.spec.patch

Comment 2 Rex Dieter 2006-02-21 15:28:35 UTC
Created attachment 124958 [details]
xmms-1.2.10-extra_libs.patch

drop gtk libs from `xmms-config --libs` output

Comment 3 Matthias Saou 2006-02-21 15:34:44 UTC
What is the reason for dropping gtk libs from the --libs output? If it's a
valid one, you'll probably also want to remove the gtk+-devel requirement
from xmms-devel, right?

Comment 4 Rex Dieter 2006-02-21 15:44:00 UTC
> What is the reason for dropping gtk libs from the --libs output?

Because they're extraneous and not needed?  (-:  
(At least as long as static libs are dropped)

xmms's headers contain
#include <gtk/gtk.h>
so I don't think droping -devel's Req: gtk+-devel is doable.

Comment 5 Matthias Saou 2006-02-21 16:07:00 UTC
Hmmm, but if xmms' headers contain that, isn't it required to link against the
gtk+ libs, thus use the --libs output?

Comment 6 Rex Dieter 2006-02-21 17:38:43 UTC
No.  libxmms.so.1 is (should-be) self-contained (ie, include no unresolved symbols).

ldd -r /usr/lib/libxmms.so.1
will show it already linked against those other libs.

Comment 7 Matthias Saou 2006-03-01 10:36:00 UTC
BTW, I think your spec file patch was against the FC-4 package as I had already
removed the static lib during my last changes, and included a Patch12 to fix
crossfade :

* Mon Feb 13 2006 Matthias Saou <http://freshrpms.net/> 1:1.2.10-20
- Spec file cleanup.
- Include crossfade 0.3.9 patch.
- Remove very old x11amp obsoletes.
- Exclude static libraries, update devel summary and description for it.
- List all plugins directories in order to be aware of breakage if the
  libtool problem ever happens again.
- Fix post/postun scriplets.
- Remove xmms_logo.xpm and xmms_mini.xpm, they should be unused.
- Add libXt-devel to fullfill the "checking for X..." configure check.
- Add gettext-devel to make more configure checks happy.

Anyway, I'll include the other patch now.

Comment 8 Matthias Saou 2006-03-09 10:01:59 UTC
The new package has been in Extras development for a while now. I'll probably
backport to FC4 soon after FC5 gets released, once it'll have gotten better
testing.


Note You need to log in before you can comment on or make changes to this bug.