Bug 1823306 - upgradeable condition msg should be updated to clearly mean a minor version upgrade blocked
Summary: upgradeable condition msg should be updated to clearly mean a minor version u...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 4.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.5.0
Assignee: W. Trevor King
QA Contact: liujia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-13 08:34 UTC by liujia
Modified: 2020-07-13 17:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:27:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-version-operator pull 356 0 None closed Bug 1823306: pkg/cvo/upgradeable: Mention "between minor versions" 2021-01-19 09:56:20 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:27:45 UTC

Description liujia 2020-04-13 08:34:32 UTC
Description of problem:
Since pr#291 landed in v4.4, now upgradeable condition is loosen to block y-level upgrade only. But the condition msg is still as following:
```
- lastTransitionTime: "2020-03-31T05:51:27Z"
      message: |-
        Multiple cluster operators cannot be upgradeable:
        * Cluster operator service-catalog-controller-manager cannot be upgraded: _Managed: Upgradeable: the controller manager is in a managed state, upgrades are not possible.
        * Cluster operator service-catalog-apiserver cannot be upgraded: _Managed: Upgradeable: the apiserver is in a managed state, upgrades are not possible.
        * Cluster operator marketplace cannot be upgraded: DprecatedAPIsInUse: The cluster has custom OperatorSource/CatalogSourceConfig, which are deprecated in future versions. Please visit this link for further deatils: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated
      reason: ClusterOperatorsNotUpgradeable
      status: "False"
      type: Upgradeable
```
- lastTransitionTime: "2020-04-09T03:48:11Z"
      message: Disabling ownership via cluster version overrides prevents upgrades.
        Please remove overrides before continuing.
      reason: ClusterVersionOverridesSet
      status: "False"
      type: Upgradeable
```

"cannot be upgradeable" and "cannot be upgraded" are not correct for a z-level upgrade actually. For users, it's mis-understanding here. Suggest to update the msg to clearly explain minor version upgrade blocked.

Version-Release number of the following components:
4.4

How reproducible:
always

Steps to Reproduce:
1. Each trigger which make upgradeable condition to be set to False will show the msg.
2.
3.

Actual results:
The condition msg is not clear that z-level version can be upgraded.

Expected results:
The upgradeable=false is only for minor version upgrade.

Additional info:
https://github.com/openshift/cluster-version-operator/pull/291

Comment 4 liujia 2020-05-13 09:34:49 UTC
Version:
4.5.0-0.nightly-2020-05-13-043728

# ./oc get clusterversion -o json|jq -r '.items[0].status.conditions[-1]'
{
  "lastTransitionTime": "2020-05-13T04:40:58Z",
  "message": "Cluster operator marketplace cannot be upgraded between minor versions: The cluster has custom OperatorSource, which is deprecated in future versions. Please visit this link for further details: https://docs.openshift.com/container-platform/4.4/release_notes/ocp-4-4-release-notes.html#ocp-4-4-marketplace-apis-deprecated",
  "reason": "DeprecatedAPIsInUse",
  "status": "False",
  "type": "Upgradeable"
}

LGTM

Comment 5 errata-xmlrpc 2020-07-13 17:27:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.