Bug 1823714 - custom display name did not change after updating on console
Summary: custom display name did not change after updating on console
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: OLM
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.5.0
Assignee: Bowen Song
QA Contact: Jian Zhang
URL:
Whiteboard:
Depends On:
Blocks: 1824274 1841171
TreeView+ depends on / blocked
 
Reported: 2020-04-14 10:35 UTC by shahan
Modified: 2020-07-13 17:27 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: updating catsrc without a new address gets skipped on updating the package manifests without reconciling other parts of the catsrc. Consequence: display name is not updated on package manifest Fix: reconcile package manifest after any catsrc update. Result: package manifest updated after following catsrc update including packageManifest.status.catalogSourceDisplayName which is based on .spec.displayName.
Clone Of:
: 1824274 1841171 (view as bug list)
Environment:
Last Closed: 2020-07-13 17:27:24 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github operator-framework operator-lifecycle-manager pull 1482 0 None closed Bug 1823714: Update PkgManifest upon catsrc update 2020-08-05 16:03:09 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:27:47 UTC

Description shahan 2020-04-14 10:35:16 UTC
Description of problem:
 custom display name did not change after updated on console

Version-Release number of selected component (if applicable):
4.5.0-0.nightly-2020-04-13-213244

How reproducible:
Always

Steps to Reproduce:
1. goto k8s/ns/openshift-marketplace/operators.coreos.com~v1alpha1~CatalogSource/~new to create new catalogsource
Catalog source name: custom-test
Display name: custom-test
Publisher name: hasha
Image (URL of container image): docker.io/aosqe/custom-keycloak:latest

2. goto operatehub page, check the filter under Provider Type
3. go back the yaml editor for custom-test, update the displayName to custom-test22
4. goto operatehub page, check the filter under Provider Type

Actual results:
2. The display name for the new catalog source is custom-test
4. after updating, the name still is custom-test

Expected results:
4. The name should be custom-test22

Additional info:
oc get CatalogSource custom-test -n openshift-marketplace --output=jsonpath='{.spec.displayName}'
custom-test22

Comment 1 Robb Hamilton 2020-04-16 14:42:46 UTC
Reassigning to OLM as based on my initial investigation, I believe this to be an OLM bug.  In the console, all we do is display `packageManifest.status.catalogSourceDisplayName`, which doesn’t get updated when `catalogSource.spec.displayName` does.

Comment 2 Daniel Messer 2020-04-23 09:54:07 UTC
Initial investigation shows that `packageManifest.status.catalogSourceDisplayName` is not reconciled on a constant basis but rather set once the CatalogSource is reconciled. E.g. killing the catalog pod triggers a reconcile and also updates packageManifest.status.catalogSourceDisplayName.

Comment 6 shahan 2020-06-02 02:25:34 UTC
update displayname for existing catalosource, the operator Hub page will update the name correspondingly
4.5.0-0.nightly-2020-06-01-165039

Comment 8 errata-xmlrpc 2020-07-13 17:27:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.