Spec URL: https://fedorapeople.org/~zvetlik/yarnpkg/yarnpkg.spec SRPM URL: https://fedorapeople.org/~zvetlik/yarnpkg/yarnpkg-1.22.4-1.fc33.src.rpm Description: Fast, reliable, and secure dependency management Fedora Account System Username: zvetlik As per https://src.fedoraproject.org/rpms/nodejs-yarn/pull-request/3
Spec is essentially identical minus the subpackage thing, so LGTM. PACKAGE APPROVED.
This is weird: #%{nodejs_symlink_deps} The macro will still expand. Is that intended?
(In reply to Miro Hrončok from comment #2) > This is weird: > > #%{nodejs_symlink_deps} > > The macro will still expand. Is that intended? The macro happens to be a single line[1], so it will be commented-out, but you're right. This should be `#%%{nodejs_symlink_deps}` for safety. Or removed entirely, of course. I suspect it's there because the standard template for Node packages would use it, but as yarn has no dependencies on other Fedora-packaged Node modules, it's unneeded. [1] ``` %nodejs_sitelib %{_prefix}/lib/node_modules %nodejs_symlink_deps %{_rpmconfigdir}/nodejs-symlink-deps %{nodejs_sitelib} ```
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/yarnpkg
I removed the %{nodejs_symlink_deps} and built the package. https://src.fedoraproject.org/rpms/yarnpkg https://koji.fedoraproject.org/koji/buildinfo?buildID=1494973