Bug 1824167 - [oauth-server] Router and default exposed frontends (oauth and console) should gracefully terminate
Summary: [oauth-server] Router and default exposed frontends (oauth and console) shoul...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: apiserver-auth
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.3.z
Assignee: Stefan Schimanski
QA Contact: pmali
URL:
Whiteboard:
Depends On: 1824166
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-15 13:22 UTC by Standa Laznicka
Modified: 2020-06-03 03:31 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1824166
Environment:
Last Closed: 2020-06-03 03:30:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-authentication-operator pull 257 0 None closed Bug 1824167: The oauth server should wait until it is out of rotation to shut down 2020-07-30 06:55:42 UTC
Red Hat Product Errata RHBA-2020:2256 0 None None None 2020-06-03 03:31:00 UTC

Description Standa Laznicka 2020-04-15 13:22:38 UTC
+++ This bug was initially created as a clone of Bug #1824166 +++

+++ This bug was initially created as a clone of Bug #1824163 +++

+++ This bug was initially created as a clone of Bug #1809665 +++

The router, console, and oauth endpoints should all gracefully terminate when their pods are marked deleted without dropping traffic.

Console and oauth can have simple "wait before shutdown" logic because they do not execute long running transactions.  The router needs to wait longer (it is a service load balancer) and then instruct HAProxy to gracefully terminate, then wait up to a limit, and then shut down.

In combination these fixes will ensure end users see no disruption of the control plane or web console, or their frontend web applications, during upgrade.

--- Additional comment from Standa Laznicka on 2020-04-15 15:16:28 CEST ---

as observed in https://testgrid.k8s.io/redhat-openshift-ocp-release-4.5-informing#release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.5&sort-by-flakiness=, this was fixed by the patch merged on 2020-03-03, thus marking verified

https://github.com/openshift/cluster-authentication-operator/pull/252

--- Additional comment from Standa Laznicka on 2020-04-15 15:21:06 CEST ---

As observed in https://testgrid.k8s.io/redhat-openshift-ocp-release-4.4-informing#release-openshift-origin-installer-e2e-aws-upgrade-rollback-4.4&sort-by-flakiness=, the bug was fixed by a PR that merged on 2020-03-12, thus marking as verified
https://github.com/openshift/cluster-authentication-operator/pull/255

Comment 1 Stefan Schimanski 2020-05-20 09:16:11 UTC
PR is tagged and will soon merge.

Comment 6 errata-xmlrpc 2020-06-03 03:30:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2256


Note You need to log in before you can comment on or make changes to this bug.