Bug 1824373 - [virt-install] need to support cell[0-9]*.memAccess option
Summary: [virt-install] need to support cell[0-9]*.memAccess option
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-16 03:28 UTC by Hekai Wang
Modified: 2020-08-31 19:52 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-31 19:52:18 UTC
Embargoed:


Attachments (Terms of Use)

Description Hekai Wang 2020-04-16 03:28:16 UTC
Description of problem:

virt-install need to support   cell[0-9]*.memAccess option

--cpu numa.cell0.memory=1234,numa.cell0.cpus=0-3,numa.cell1.memory=5678,numa.cell1.cpus=4-7
Example of specifying two NUMA cells. This will generate XML like:

  <cpu>
    <numa>
      <cell cpus="0-3" memory="1234"/>
      <cell cpus="4-7" memory="5678"/>
    </numa>
  </cpu>
--cpu host-passthrough,cache.mode=passthrough
Example of passing through the host cpu's cache information.

Use --cpu=? to see a list of all available sub options. Complete details at <https://libvirt.org/formatdomain.html#elementsCPU>

because this option exists in libvirt


Version-Release number of selected component (if applicable):


How reproducible:
Always 


Steps to Reproduce:

[]# virt-install --connect=qemu:///system   --name=wanghekai --disk path=/tmp/kaizi.qcow2,format=qcow2 --ram 8192 --memorybacking hugepages=on,size=1024,unit=M,nodeset=0   --vcpus=4,cpuset=3,4,5,6   --check-cpu --cpu Haswell-noTSX,+pdpe1gb,cell0.id=0,cell0.cpus=0,cell0.memory=8388608,cell0.memAccess=yes --numatune mode=strict,nodeset=0   --nographics --noautoconsole   --import   --os-variant=rhel7
ERROR    Unknown options ['cell0.memAccess']
[root@dell-per740-40 tmp]# virt-install --connect=qemu:///system   --name=vm1 --disk path=/tmp/kaizi.qcow2,format=qcow2 --ram 8192 --memorybacking hugepages=on,size=1024,unit=M,nodeset=0   --vcpus=4,cpuset=3,4,5,6   --check-cpu --cpu Haswell-noTSX,+pdpe1gb,cell0.id=0,cell0.cpus=0,cell0.memory=8388608,cell0.memAccess=yes --numatune mode=strict,nodeset=0   --nographics --noautoconsole   --import   --os-variant=rhel7
ERROR    Unknown options ['cell0.memAccess']



[]# virt-install --connect=qemu:///system   --name=vm2 --disk path=/tmp/kaizi.qcow2,format=qcow2 --ram 8192 --memorybacking hugepages=on,size=1024,unit=M,nodeset=0   --vcpus=4,cpuset=3,4,5,6   --check-cpu --cpu Haswell-noTSX,+pdpe1gb,cell0.id=0,cell0.cpus=0,cell0.memory=8388608 --numatune mode=strict,nodeset=0   --nographics --noautoconsole   --import   --os-variant=rhel7

Starting install...
Domain creation completed.

[]# virt-install --cpu=?
--cpu options:
  cache.level
  cache.mode
  cell[0-9]*.cpus
  cell[0-9]*.distances.sibling[0-9]*.id
  cell[0-9]*.distances.sibling[0-9]*.value
  cell[0-9]*.id
  cell[0-9]*.memory
  clearxml
  disable
  forbid
  force
  match
  mode
  model
  optional
  require
  secure
  vendor

1.
2.
3.

Actual results:
ERROR    Unknown options ['cell0.memAccess']


Expected results:
It support this option.

Additional info:

Comment 1 Cole Robinson 2020-08-31 19:52:18 UTC
Thanks for the report. Implemented upstream now

commit b3fb88e3450a20b4d64c4cd890e0afdccc58e4e8 (HEAD -> master, origin/master, origin/HEAD)
Author: Cole Robinson <crobinso>
Date:   Mon Aug 31 13:53:26 2020 -0400

    cli: Add --cpu numa.cell.memAccess and discard
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1824373


Note You need to log in before you can comment on or make changes to this bug.