Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rubygem-optimist.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rubygem-optimist-3.0.0-1.fc33.src.rpm Description: Commandline option parser for Ruby. Fedora Account System Username: ignatenkobrain
I think you should add "%exclude %{gem_cache}" to the %files section. While it's not mentioned in the packaging guidelines, but this is generated by gem2rpm, and this is what existing rubygem packages do as well. You also need to own "%dir %{gem_instdir}", otherwise that directory is unowned. Please fix those two issues before importing the package. Full review below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [-]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gems/gems/optimist-3.0.0 [x]: Package must own all directories that it creates. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: Avoid bundling fonts in non-fonts packages. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: When checking ruby code, install the ruby plugin. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-optimist-3.0.0-1.fc33.noarch.rpm rubygem-optimist-doc-3.0.0-1.fc33.noarch.rpm rubygem-optimist-3.0.0-1.fc33.src.rpm rubygem-optimist.noarch: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commandment rubygem-optimist.noarch: W: spelling-error %description -l en_US Commandline -> Command line, Command-line, Commandment rubygem-optimist.noarch: W: no-documentation rubygem-optimist.src: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commandment rubygem-optimist.src: W: spelling-error %description -l en_US Commandline -> Command line, Command-line, Commandment 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- rubygem-optimist.noarch: W: spelling-error Summary(en_US) Commandline -> Command line, Command-line, Commandment rubygem-optimist.noarch: W: spelling-error %description -l en_US Commandline -> Command line, Command-line, Commandment rubygem-optimist.noarch: W: invalid-url URL: https://rubygems.org/gems/optimist <urlopen error [Errno -2] Name or service not known> rubygem-optimist.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://rubygems.org/downloads/optimist-3.0.0.gem : CHECKSUM(SHA256) this package : 9248b63be64ee1516f2e1a1d98d8528571eb2a48399e19188db1d865c7cd5d16 CHECKSUM(SHA256) upstream package : 9248b63be64ee1516f2e1a1d98d8528571eb2a48399e19188db1d865c7cd5d16 Requires -------- rubygem-optimist (rpmlib, GLIBC filtered): ruby(rubygems) rubygem-optimist-doc (rpmlib, GLIBC filtered): rubygem-optimist Provides -------- rubygem-optimist: rubygem(optimist) rubygem-optimist rubygem-optimist-doc: rubygem-optimist-doc Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1824780 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, Perl, fonts, R, SugarActivity, Haskell, Java, Ocaml, PHP, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-optimist
It seems that the package does not own the `%{gem_instdir}` in any way.
(In reply to Fabio Valentini from comment #1) > I think you should add "%exclude %{gem_cache}" to the %files section. > While it's not mentioned in the packaging guidelines, but this is generated > by gem2rpm, and this is what existing rubygem packages do as well. > > You also need to own "%dir %{gem_instdir}", otherwise that directory is > unowned. > > Please fix those two issues before importing the package. ↑ I noted this in the review, but apparently Igor didn't see that ...
> %dir %{gem_instdir} is in the spec file, no?
"%dir %{gem_instdir}" needs to be in the main package (not in the -doc subpackage). https://src.fedoraproject.org/rpms/rubygem-optimist/blob/master/f/rubygem-optimist.spec#_61
Ah, now I see... Will fix it in a bit.
(In reply to Fabio Valentini from comment #4) > (In reply to Fabio Valentini from comment #1) > > I think you should add "%exclude %{gem_cache}" to the %files section. > > While it's not mentioned in the packaging guidelines, but this is generated > > by gem2rpm, and this is what existing rubygem packages do as well. > > > > You also need to own "%dir %{gem_instdir}", otherwise that directory is > > unowned. > > > > Please fix those two issues before importing the package. > > ↑ I noted this in the review, but apparently Igor didn't see that ... Neither did I, sorry ;D