Spec URL: https://tagoh.fedorapeople.org/reviews/hanamin-fonts/hanamin-fonts.spec SRPM URL: https://tagoh.fedorapeople.org/reviews/hanamin-fonts/hanamin-fonts-20170904-8.fc33.src.rpm Description: Hanazono Mincho typeface is a Japanese TrueType font that developed with a support of Grant-in-Aid for Publication of Scientific Research Results from Japan Society for the Promotion of Science and the International Research Institute for Zen Buddhism (IRIZ), Hanazono University. also with volunteers who work together on glyphwiki.org. Fedora Account System Username: tagoh
This is to rename hanazono-fonts.
Ok, quick review: 1. the spec applies official Fedora font templates 2. you do not strictly need the common_description indirection when generating a single font package, but it does no wrong either 4. since we only ship OpenType fonts nowadays, maybe it is not useful to remind the font family format in Summary and description 5. usual rpmlint checking as required in review: $ rpmlint /srv/rpm/fonts-rpm-macros/hanamin-fonts-20170904.fc33.noarch.rpm hanamin-fonts.noarch: W: spelling-error %description -l en_US Hanazono -> Shannon hanamin-fonts.noarch: W: spelling-error %description -l en_US glyphwiki -> glyph wiki, glyph-wiki, hieroglyph hanamin-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hanamin-fonts/README.txt hanamin-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/hanamin-fonts/THANKS.txt Please fix the wrong-file-end-of-line-encoding,warnings using %linuxtext or any other method Thanks for the conversion APPROVED
I thought this can be packaged like this https://download.copr.fedorainfracloud.org/results/pnemade/fedora-review/fedora-rawhide-x86_64/01345510-hanamin-fonts/hanamin-fonts.spec
Hi Parag spec cleanliness aside (and I don’t pretend to be a CJK expert) I think Akira is right, we’re not in presence of two font families, but a single one, split over two files to workaround the OpenType pre-file glyph number limit. And that will work fine because fontconfig will merge the files as a single family. While fc-scan -f "%{family[0]};%{style[0]};%{fullname[0]};%{width};%{weight};%{slant};%{fontversion};%{file}\n" /usr/share/fonts/clm-* |sort -t ';' -k1,1d -k4,4n -k5,5n -k6,6n -k2,2d -k7,7dr | uniq | column --separator ';' -t is horrible from a usability POW, its results are useful
Thank you, I understood this font family packaging now.
Fixed doc thing and requested creating new repo for this now. Thank you for the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/hanamin-fonts
The package can't be built: https://kojipkgs.fedoraproject.org//work/tasks/7968/44477968/build.log
Okay, the package has been built on rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1516776