Bug 1825193 - Running 'strip' fails on BPF bytecode files
Summary: Running 'strip' fails on BPF bytecode files
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: binutils
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-17 11:02 UTC by Toke Høiland-Jørgensen
Modified: 2021-11-30 16:26 UTC (History)
6 users (show)

Fixed In Version: binutils-2.34.0-7.fc33
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-30 16:26:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Toke Høiland-Jørgensen 2020-04-17 11:02:13 UTC
Description of problem:
The 'strip' binary fails to recognise BPF bytecode files, such as those shipped with the xdp-tools package. This means building of the xdp-tools package fails unless a work-around is enabled (disabling 'brp_strip' and 'brp_strip_lto' entirely).


Steps to Reproduce:
Run 'strip' on a .o file containing BPF byte code

Actual results:
/usr/bin/strip: Unable to recognise the format of the input file `/home/rpmbuild/BUILDROOT/xdp-tools-0.0.3-1.fc33.x86_64/usr/lib64/bpf/xdpdump_bpf.o'


Expected results:
No error

Comment 1 Nick Clifton 2020-04-17 15:53:54 UTC
Hi Toke,

  Would you mind uploading a BPF byte code file that I can use for tests ?  It would make my life a lot easier...

Cheers
  Nick

Comment 2 Nick Clifton 2020-04-17 16:12:41 UTC
(In reply to Nick Clifton from comment #1)
Never mind - I have created my own...

Comment 3 Toke Høiland-Jørgensen 2020-04-17 16:14:50 UTC
Right, cool. You can also just 'dnf install xdp-tools' and look in $LIBDIR/bpf/ :)

Comment 4 Nick Clifton 2020-04-20 15:48:28 UTC
Hi Toke,

  Right - this should be resolved in the current rawhide version of the binutils (2.34-3.fc33).

Cheers
  Nick

Comment 5 Toke Høiland-Jørgensen 2020-04-21 11:21:56 UTC
Yup, can confirm that the xdp-tools RPM now builds without the workarounds - thanks! :)

Comment 6 Toke Høiland-Jørgensen 2020-06-15 15:03:00 UTC
Hmm, was it on purpose that you didn't add BPF to the s390 target? Getting a build error for xdp-tools for that arch only now:

https://koji.fedoraproject.org/koji/taskinfo?taskID=45751621

Comment 7 Nick Clifton 2020-06-16 11:39:29 UTC
(In reply to Toke Høiland-Jørgensen from comment #6)
> Hmm, was it on purpose that you didn't add BPF to the s390 target?

It doesn't build.  I am trying to fix this now.

Comment 8 Nick Clifton 2020-06-16 20:28:52 UTC
Hi Toke,

  Please try: binutils-2.34.0-7.fc33 
  
  You might find this version to be a bit problematical as I could not find a way to just build ld.gold and ld.bfd with s390x and bpf support.  Instead I had to enable support for *all* targets, which will make both linkers a lot bigger...

Cheers
  Nick

Comment 9 Toke Høiland-Jørgensen 2020-06-17 09:51:11 UTC
Yup, build succeeded:
https://koji.fedoraproject.org/koji/taskinfo?taskID=45820017

Thanks!

Comment 10 Ben Cotton 2020-08-11 13:18:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 11 Ben Cotton 2021-11-04 17:29:55 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 12 Ben Cotton 2021-11-30 16:26:57 UTC
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.