Bug 182533 - Firefox Printing enhancement (pango)
Summary: Firefox Printing enhancement (pango)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: firefox
Version: 5.0
Hardware: All
OS: Linux
high
high
Target Milestone: ---
: ---
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard: notFC5,pm-20061020
Depends On: firefoxprinting
Blocks: 182695 183390
TreeView+ depends on / blocked
 
Reported: 2006-02-23 02:19 UTC by Leon Ho
Modified: 2007-11-30 22:07 UTC (History)
6 users (show)

Fixed In Version: 5.0.0
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-09 09:10:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
The patch (150.66 KB, patch)
2006-10-21 16:42 UTC, Behdad Esfahbod
no flags Details | Diff
updated patch (150.92 KB, patch)
2006-10-23 18:18 UTC, Behdad Esfahbod
no flags Details | Diff

Comment 23 Behdad Esfahbod 2006-10-21 16:42:43 UTC
Created attachment 139059 [details]
The patch

Attaching the patch here for testing.  I'm still performing some final tweaks
on it, but that's basically it.

What I've not tested:

  - Positioned glyphs that require non-zero x or y offset.

What I'm still doing:

  - Deciding what the right size for generated bitmap fonts should be.

Comment 24 Behdad Esfahbod 2006-10-21 16:44:18 UTC
Sample outputs available here:

  http://www.gnome.org/~behdad/FirefoxPangoPrinting/

Comment 25 Behdad Esfahbod 2006-10-23 18:18:13 UTC
Created attachment 139151 [details]
updated patch

Ok, this is supposed to fix the bitmap sizing issue, but I get slightly
spaced-out bitmap fonts currently.  For some reason the bitmap is rendered at
100dpi instead of 72dpi that it should be.  This looks more like a
pango/fontconfig issue to me.  So, this patch can go in.

Comment 26 Behdad Esfahbod 2006-10-23 22:50:39 UTC
Upstreamed: https://bugzilla.mozilla.org/show_bug.cgi?id=357733

Comment 29 A S Alam 2006-10-30 10:07:30 UTC
bug 212336 (Indic][Print] gedit is print square box, when try to print ZWJ in
word (Ref bug 211574)) is effecting this bug.. 

Comment 30 Paul Gampe 2006-10-30 22:32:02 UTC
Hi Alam, This bug was for Firefox to switch to Pango for print rendering which 
is now complete.  Is it OK to move this bug back to modified as that part is 
complete and can be tested independent of specific rendering bugs you may find 
in Pango.

I think it is correct that you continue to open bugs against pango as you have 
done for bug 212336 etc.

Comment 32 Matthias Clasen 2006-11-03 01:36:17 UTC
Moving back to MODIFIED as per comment #30


Note You need to log in before you can comment on or make changes to this bug.