Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-netbox-netbox.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-netbox-netbox-0.1.10-1.fc33.src.rpm Description: Netbox modules for Ansible. Fedora Account System Username: ignatenkobrain
Taking this review.
This package does not build, as the %ansible_* macros are undefined as is. Is there a missing build dependency?
New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-netbox-netbox.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-netbox-netbox-0.1.10-1.fc33.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ansible/collections/ansible_collections [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ansible/collections/ansible_collections [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ansible-collection-netbox-netbox-0.1.10-1.fc33.noarch.rpm ansible-collection-netbox-netbox-0.1.10-1.fc33.src.rpm ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.github ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.github ansible-collection-netbox-netbox.noarch: E: version-control-internal-file /usr/share/ansible/collections/ansible_collections/netbox/netbox/.gitignore ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.travis.yml ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_aggregate.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit_termination.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_bay.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_interface.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_inventory_item.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_ip_address.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_ipam_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_manufacturer.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_platform.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_prefix.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_provider.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_region.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rir.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_service.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_site.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_tenant.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_tenant_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_virtual_machine.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vlan.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vlan_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vm_interface.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vrf.py 644 /usr/bin/python ansible-collection-netbox-netbox.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-netbox-netbox.src: W: invalid-url URL %{ansible_collection_url} 2 packages and 0 specfiles checked; 34 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- ansible-collection-netbox-netbox.noarch: W: invalid-url URL: https://galaxy.ansible.com/netbox/netbox <urlopen error [Errno -2] Name or service not known> ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.github ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.github ansible-collection-netbox-netbox.noarch: E: version-control-internal-file /usr/share/ansible/collections/ansible_collections/netbox/netbox/.gitignore ansible-collection-netbox-netbox.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/netbox/netbox/.travis.yml ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_aggregate.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit_termination.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_circuit_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_cluster_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_bay.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_interface.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_device_type.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_inventory_item.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_ip_address.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_ipam_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_manufacturer.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_platform.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_prefix.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_provider.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rack_role.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_region.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_rir.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_service.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_site.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_tenant.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_tenant_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_virtual_machine.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vlan.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vlan_group.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vm_interface.py 644 /usr/bin/python ansible-collection-netbox-netbox.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/netbox_vrf.py 644 /usr/bin/python 1 packages and 0 specfiles checked; 34 errors, 4 warnings. Source checksums ---------------- https://github.com/netbox-community/ansible_modules/archive/v0.1.10/ansible-collection-netbox-netbox-0.1.10.tar.gz : CHECKSUM(SHA256) this package : e02be6f4734235f30ff4ef7e15e408e76b619619ad17bceeaf505badf032a3c4 CHECKSUM(SHA256) upstream package : e02be6f4734235f30ff4ef7e15e408e76b619619ad17bceeaf505badf032a3c4 Requires -------- ansible-collection-netbox-netbox (rpmlib, GLIBC filtered): (ansible >= 2.9.0 with ansible < 2.10.0) python3.8dist(pynetbox) Provides -------- ansible-collection-netbox-netbox: ansible-collection(netbox.netbox) ansible-collection-netbox-netbox Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1825606 -m fedora-rawhide-x86_64 -o --no-cleanup-after --no-clean --no-bootstrap-chroot --enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, SugarActivity, Python, Haskell, Ocaml, C/C++, PHP, R, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Review notes: * /usr/share/ansible/collections/ansible_collections needs to be owned by "ansible" * /usr/share/ansible/collections/ansible_collections/netbox/netbox/plugins/modules/*.py needs /usr/bin/python shebangs stripped * No other serious issues PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-netbox-netbox