Bug 1826252 - preserve integers decoding raw JSON values
Summary: preserve integers decoding raw JSON values
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: kube-apiserver
Version: 4.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.5.0
Assignee: Lukasz Szaszkiewicz
QA Contact: Ke Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-21 10:22 UTC by Lukasz Szaszkiewicz
Modified: 2020-07-13 17:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:29:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift origin pull 24879 0 None closed Bug 1826252: preserve integers decoding raw JSON values 2020-06-23 10:10:35 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:29:46 UTC

Description Lukasz Szaszkiewicz 2020-04-21 10:22:58 UTC
move https://github.com/kubernetes/kubernetes/pull/89833 into origin that fixes a bug defining a default value for a replicas field in a custom resource definition that has the scale subresource enabled

Comment 3 Ke Wang 2020-04-28 07:35:17 UTC
Per upstream PR https://github.com/kubernetes/kubernetes/pull/89833, this bug involves kube-openapi number/integer validation and related tests. So to verify it, we have to run related unit tests.

First, confirmed that the fix has been in latest OCP build 4.5.0-0.nightly-2020-04-27-204255,
$ oc adm release info --commits registry.svc.ci.openshift.org/ocp/release:4.5.0-0.nightly-2020-04-27-204255 |grep origin
...
  tests                                          https://github.com/openshift/origin                                         3be2bc25e67441e67a682a790352a568e5b37144

$ git log --date local --pretty="%h %an %cd - %s" 3be2bc25 | grep -i '#24879'                                                                    
b3d92878a2 OpenShift Merge Robot Tue Apr 21 20:17:36 2020 - Merge pull request #24879 from p0lyn0mial/crd-preserve-integers

Run the related unit tests to verify, 
$ cd openshift/origin/vendor/k8s.io/kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema
$ go test -v -run Test*
...
=== RUN   TestStructuralRoundtripOrError                                              
--- PASS: TestStructuralRoundtripOrError (0.40s)                                      
    convert_test.go:36: seed = 1588058196223859844                                                                                                                           
=== RUN   TestStructuralRoundtrip                                                                                                                                            
--- PASS: TestStructuralRoundtrip (1.64s)                                             
    goopenapi_test.go:36: seed = 1588058196621510950                                                                                                                         
=== RUN   TestStructuralUnfoldIntOrString                                                                                                                                    
--- PASS: TestStructuralUnfoldIntOrString (0.00s)                                     
=== RUN   TestValidateNestedValueValidationComplete                                                                                                                          
--- PASS: TestValidateNestedValueValidationComplete (0.00s)                                                                                                                  
PASS                                                                                                                                                                         
ok      k8s.io/apiextensions-apiserver/pkg/apiserver/schema     2.069s

Related tests all are passed, move the bug verify.

Comment 4 errata-xmlrpc 2020-07-13 17:29:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.