Bug 1826855 - [cnv&rhv] update of cpu on cnv side causing expetion in engine.log
Summary: [cnv&rhv] update of cpu on cnv side causing expetion in engine.log
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.4.0
Hardware: All
OS: All
medium
medium
Target Milestone: ovirt-4.4.1
: 4.4.1
Assignee: Piotr Kliczewski
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-22 16:12 UTC by Pavol Brilla
Modified: 2020-08-04 13:23 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.4.0
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-04 13:22:48 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
traceback from engine.log (25.20 KB, text/plain)
2020-04-22 16:12 UTC, Pavol Brilla 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:3247 0 None None None 2020-08-04 13:23:02 UTC
oVirt gerrit 108596 0 master MERGED kubevirt: allow to update all params when vm is running 2020-07-09 17:48:38 UTC

Description Pavol Brilla 2020-04-22 16:12:10 UTC 
Created attachment 1680924 [details]
traceback from engine.log

Description of problem:
Yaml of CNv VM was changed:
    spec:
      domain:
        cpu:
          cores: 1
          sockets: 2
          threads: 1


Version-Release number of selected component (if applicable):
cnv 2.3 on 4.4
rhv 4.4 beta -33

How reproducible:
100

Steps to Reproduce:
1. change yaml cnv vm
2. check engine.log for tracebacks

Actual results:
no update on rhv side 

Expected results:
instead of traceback, have vm properties updated

Additional info:
Dev has access to env
Comment 1 Piotr Kliczewski 2020-04-22 16:16:11 UTC 
Here is the stacktrace:

2020-04-22 17:55:11,962+02 INFO  [org.ovirt.engine.core.bll.UpdateVmCommand] (pool-21-thread-1) [1b3a895f] Running command: UpdateVmCommand internal: true. Entities affected :  ID: 6980e15e-ef31-46bb-9419-9086b60c850e Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2020-04-22 17:55:12,281+02 INFO  [org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand] (pool-21-thread-1) [34aadbdc] Running command: HotSetNumberOfCpusCommand internal: true. Entities affected :  ID: 6980e15e-ef31-46bb-9419-9086b60c850e Type: VMAction group EDIT_VM_PROPERTIES with role type USER
2020-04-22 17:55:12,323+02 INFO  [org.ovirt.engine.core.vdsbroker.SetNumberOfCpusVDSCommand] (pool-21-thread-1) [34aadbdc] START, SetNumberOfCpusVDSCommand(HostName = talayan-pytest-8rq2p-worker-t89wj, Params:{hostId='995cc546-74f6-4e78-be9e-6c72fbd18f4c', vmId='6980e15e-ef31-46bb-9419-9086b60c850e', numberOfCpus='2'}), log id: 1a804dd8
2020-04-22 17:55:12,324+02 ERROR [org.ovirt.engine.core.vdsbroker.SetNumberOfCpusVDSCommand] (pool-21-thread-1) [34aadbdc] Command 'SetNumberOfCpusVDSCommand(HostName = talayan-pytest-8rq2p-worker-t89wj, Params:{hostId='995cc546-74f6-4e78-be9e-6c72fbd18f4c', vmId='6980e15e-ef31-46bb-9419-9086b60c850e', numberOfCpus='2'})' execution failed: null
2020-04-22 17:55:12,324+02 INFO  [org.ovirt.engine.core.vdsbroker.SetNumberOfCpusVDSCommand] (pool-21-thread-1) [34aadbdc] FINISH, SetNumberOfCpusVDSCommand, return: , log id: 1a804dd8
2020-04-22 17:55:12,336+02 ERROR [org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand] (pool-21-thread-1) [34aadbdc] Command 'org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand' failed: null
2020-04-22 17:55:12,336+02 ERROR [org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand] (pool-21-thread-1) [34aadbdc] Exception: java.lang.NullPointerException
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.HotSetNumberOfCpusCommand.executeCommand(HotSetNumberOfCpusCommand.java:107)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1169)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1327)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:2003)
        at org.ovirt.engine.core.utils//org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:140)
Comment 2 Sandro Bonazzola 2020-06-05 07:10:04 UTC 
$ git tag --contains 2dfebce5f9de48290fde0fcf50a1138042e715ac
ovirt-engine-4.4.0
ovirt-engine-4.4.0.1
ovirt-engine-4.4.0.2
ovirt-engine-4.4.0.3
ovirt-engine-4.4.1
ovirt-engine-4.4.1.1
ovirt-engine-4.4.1.2
Comment 7 Pavol Brilla 2020-07-09 17:58:19 UTC 
2020-07-09 19:57:26,653+02 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (pool-57-thread-1) [19cad5c2] EVENT_ID: SYSTEM_UPDATE_VM(253), VM cirros-vm-notfromtemplate configuration was updated by system.
2020-07-09 19:57:26,654+02 INFO  [org.ovirt.engine.core.bll.UpdateVmCommand] (pool-57-thread-1) [19cad5c2] Lock freed to object 'EngineLock:{exclusiveLocks='[cirros-vm-notfromtemplate=VM_NAME]', sharedLocks='[08e73976-e63f-46f1-baae-0f84e9bae728=VM]'}'
2020-07-09 19:57:26,654+02 INFO  [org.ovirt.engine.core.bll.kubevirt.VMsMonitoring] (pool-57-thread-1) [19cad5c2] vm cirros-vm-notfromtemplate updated!


Software Version:4.4.1.5-0.17.el8ev
Comment 9 errata-xmlrpc 2020-08-04 13:22:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247
Note You need to log in before you can comment on or make changes to this bug.