Bug 1827127 - [v2v] Disable the playbook log download when it has not run.
Summary: [v2v] Disable the playbook log download when it has not run.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.11.4
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.11.6
Assignee: Mike Turley
QA Contact: Md Nadeem
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On: 1842806
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-23 10:04 UTC by Ilanit Stein
Modified: 2022-11-14 05:04 UTC (History)
5 users (show)

Fixed In Version: 5.11.6.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-10 13:39:10 UTC
Category: Bug
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:
pm-rhel: cfme-5.11.z+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:2480 0 None None None 2020-06-10 13:39:20 UTC

Description Ilanit Stein 2020-04-23 10:04:38 UTC
Description of problem:
In case the configure conversion host ansible playbook is not run, the playbook log file download should be disabled. 

Version-Release number of selected component (if applicable):
CFME-5.11.5.1
RHV-4.3

How reproducible:
an example for a case were this ansible playbook is not run is in this  
Bug 1810135 - "[v2v] Add a check that conversion host VM has least one IP address in the inventory". 
The conversion host VM did not have IP address, and thus the conversion host playbook was not ran.

Comment 2 Fabien Dupont 2020-04-23 12:28:00 UTC
When the playbook has not run, the 'context_data' attribute of the task doesn't have a field named 'conversion_host_enable' (or 'conversion_host_check', or 'conversion_host_disable').

Comment 4 CFME Bot 2020-05-11 21:51:29 UTC
New commit detected on ManageIQ/manageiq-v2v/ivanchuk:

https://github.com/ManageIQ/manageiq-v2v/commit/6ae2d20d2425a03de491e22ce078791a2bd86d54
commit 6ae2d20d2425a03de491e22ce078791a2bd86d54
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Mon May 11 11:57:29 2020 +0000
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Mon May 11 11:57:29 2020 +0000

    Merge pull request #1131 from mturley/bz1827127-disable-playook-log-while-running

    [BZ#1827127] Disable conversion host log download when playbook has not run

    (cherry picked from commit d1d4ab8f2886428aba462cbd7d23cb90296f36d7)

    https://bugzilla.redhat.com/show_bug.cgi?id=1827127

 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 12 +-
 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostsListItem.test.js | 41 +-
 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsListItem.test.js.snap | 9 +
 3 files changed, 59 insertions(+), 3 deletions(-)

Comment 5 CFME Bot 2020-05-11 21:51:32 UTC
New commit detected on ManageIQ/manageiq-v2v/jansa:

https://github.com/ManageIQ/manageiq-v2v/commit/fcc6d3f48d2bd010bb15a878621ece7bcee95c6f
commit fcc6d3f48d2bd010bb15a878621ece7bcee95c6f
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Mon May 11 11:57:29 2020 +0000
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Mon May 11 11:57:29 2020 +0000

    Merge pull request #1131 from mturley/bz1827127-disable-playook-log-while-running

    [BZ#1827127] Disable conversion host log download when playbook has not run

    (cherry picked from commit d1d4ab8f2886428aba462cbd7d23cb90296f36d7)

    https://bugzilla.redhat.com/show_bug.cgi?id=1827127

 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 12 +-
 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/ConversionHostsListItem.test.js | 41 +-
 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsListItem.test.js.snap | 9 +
 3 files changed, 59 insertions(+), 3 deletions(-)

Comment 7 Mike Turley 2020-06-01 17:58:58 UTC
@Md Nadeem,

Looking at the appliance, I don't see an item for auto-conv-osp-instance3 in the conversion host settings page, you must have removed it. Can you run the configuration again?

This message appears in the log file, not in the UI, correct? I think this is expected behavior. If the playbook fails, we want the log to be available so the user can see in detail why it failed. As I understand it, the log download should only be disabled if the playbook failed to start at all (i.e. there is no log to download, so it would just fail to download).

Fabien, can you verify this?

Comment 8 Md Nadeem 2020-06-02 07:30:06 UTC
@Mike Turley 

Thank you for the response.

Yes, the message appear in log file and I am agree with you on the point it should allow to download the log if playbook run.

To reproduce the issue, I have tried to configure a conversion host(having no ip associated), However the detail of the conversion not appeared on conversion host page once the configuration widget gets closed. This behavior block me to verify this BZ.

I have logged a new BZ for this unexpected behavior.

>> https://bugzilla.redhat.com/show_bug.cgi?id=1842806

Comment 9 Mike Turley 2020-06-02 16:43:03 UTC
It sounds like what you observed initially is the expected behavior. Thanks for opening the separate BZ for the new issue.

Comment 13 errata-xmlrpc 2020-06-10 13:39:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:2480


Note You need to log in before you can comment on or make changes to this bug.