Spec Name or Url: http://fedora.lowlatency.de/review/libnasl.spec SRPM Name or Url: http://fedora.lowlatency.de/review/libnasl-2.2.6-1.src.rpm Description: The Nessus Security Scanner includes NASL, (Nessus Attack Scripting Language) a language designed to write security test easily and quickly.
Some tuneups (see #182743 for details) :) http://fedora.lowlatency.de/review/libnasl-2.2.6-2.src.rpm http://fedora.lowlatency.de/review/libnasl.spec
A number of compile warnings due to integers and pointers. It'd be nice if upstream fixed them. Minor: * Duplicate BuildRequires: libpcap (by nessus-libraries-devel), tetex-dvips (by tetex-latex) Good: - rpmlint checks return: rpmlint of libnasl: W: libnasl non-conffile-in-etc /etc/pki/nessus/nessus_org.pem not really conf file, can ignore rpmlint of libnasl-devel: E: libnasl-devel only-non-binary-in-usr-lib symlink, can ignore - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED
Fixed the BR. Imported and pushed :) Thanks for the review.