Bug 1827600 - Fix MachineConfig CRD openAPI validation regression
Summary: Fix MachineConfig CRD openAPI validation regression
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Machine Config Operator
Version: 4.5
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 4.5.0
Assignee: Christian Glombek
QA Contact: Michael Nguyen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-24 10:00 UTC by Christian Glombek
Modified: 2020-07-13 17:31 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-13 17:31:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift machine-config-operator pull 1677 0 None closed Bug 1827600: Fix crd openAPI validation regression 2020-06-23 10:22:39 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:31:28 UTC

Description Christian Glombek 2020-04-24 10:00:52 UTC
Description of problem:
PR #1474 introduced a regression on the openAPI validation scheme of the MachineConfig CRD.

Comment 5 Michael Nguyen 2020-05-05 15:29:33 UTC
Verified on 4.5.0-0.nightly-2020-05-04-103637.  Applied MachineConfig.Spec.Config.Replace.Source without any OpenAPI errors.

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-05-04-103637   True        False         29m     Cluster version is 4.5.0-0.nightly-2020-05-04-103637
$ cat file.yaml 
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: test-file
spec:
  config:
    ignition:
      version: 2.2.0
      config:
        replace:
          source: https://raw.githubusercontent.com/mike-nguyen/misc/master/remote.yaml
$ oc apply -f file.yaml 
machineconfig.machineconfiguration.openshift.io/test-file created
$ oc get mc
NAME                                                        GENERATEDBYCONTROLLER                      IGNITIONVERSION   AGE
00-master                                                   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
00-worker                                                   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
01-master-container-runtime                                 339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
01-master-kubelet                                           339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
01-worker-container-runtime                                 339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
01-worker-kubelet                                           339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
99-master-9ffc0f02-c9af-46d5-badd-587c55727861-registries   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
99-master-ssh                                                                                          2.2.0             53m
99-worker-85584545-4610-4989-9efa-5b9835c1fdf8-registries   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
99-worker-ssh                                                                                          2.2.0             53m
rendered-master-d4ff086b3e94a0bdda818b3ae2fc6e10            339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
rendered-worker-990aa2e549753acde7487aedf6aa1eed            339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             46m
test-file                                                                                              2.2.0             2s
$ oc get mc
NAME                                                        GENERATEDBYCONTROLLER                      IGNITIONVERSION   AGE
00-master                                                   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
00-worker                                                   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
01-master-container-runtime                                 339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
01-master-kubelet                                           339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
01-worker-container-runtime                                 339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
01-worker-kubelet                                           339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
99-master-9ffc0f02-c9af-46d5-badd-587c55727861-registries   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
99-master-ssh                                                                                          2.2.0             53m
99-worker-85584545-4610-4989-9efa-5b9835c1fdf8-registries   339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
99-worker-ssh                                                                                          2.2.0             53m
rendered-master-d4ff086b3e94a0bdda818b3ae2fc6e10            339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
rendered-worker-990aa2e549753acde7487aedf6aa1eed            339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             47m
rendered-worker-9dda83e61d671a0594f72c5d4b5402a8            339d3372ea05058fb0d85266c13ee3e7399239b6   2.2.0             20s
test-file                                                                                              2.2.0             25s
$ oc get mcp/worker
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-990aa2e549753acde7487aedf6aa1eed   False     True       False      3              0                   0                     0                      47m                                                 testcluster

$ oc get mcp/worker
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
worker   rendered-worker-9dda83e61d671a0594f72c5d4b5402a8   True      False      False      3              3                   3                     0                      72m

Comment 6 errata-xmlrpc 2020-07-13 17:31:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.