Bug 1827745 - Python 3.8: module 'cgi' has no attribute 'escape'
Summary: Python 3.8: module 'cgi' has no attribute 'escape'
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: urlwatch
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabian Affolter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-04-24 17:11 UTC by Francisco de la Peña
Modified: 2021-05-25 15:59 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-25 15:59:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github thp urlwatch issues 477 0 None closed Python 3.8: module 'cgi' has no attribute 'escape' 2021-01-09 22:45:20 UTC

Description Francisco de la Peña 2020-04-24 17:11:40 UTC
Description of problem:

urlwatch uses cgi.escape which was deprecated in Python 3.7 and removed in 3.8.
A possible alternative is html.escape.

How to reproduce:

Create a rule, e.g.:

kind: url
name: Example
url: https://example.org/
filter: xpath://*[@id="someid"]

Then, make some change in the document and run urlwatch. It will return the following:

Traceback (most recent call last):
  File "/usr/bin/urlwatch", line 111, in <module>
    urlwatch_command.run()
  File "/usr/lib/python3.8/site-packages/urlwatch/command.py", line 295, in run
    self.urlwatcher.close()
  File "/usr/lib/python3.8/site-packages/urlwatch/main.py", line 99, in close
    self.report.finish()
  File "/usr/lib/python3.8/site-packages/urlwatch/handler.py", line 159, in finish
    ReporterBase.submit_all(self, self.job_states, duration)
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 103, in submit_all
    subclass(report, cfg, job_states, duration).submit()
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 408, in submit
    body_html = '\n'.join(self.convert(HtmlReporter).submit())
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 149, in submit
    yield from (str(part) for part in self._parts())
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 149, in <genexpr>
    yield from (str(part) for part in self._parts())
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 183, in _parts
    yield SafeHtml(title).format(verb=job_state.verb,
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 144, in format
    **{k: cgi.escape(str(v)) for k, v in kwargs.items()})
  File "/usr/lib/python3.8/site-packages/urlwatch/reporters.py", line 144, in <dictcomp>
    **{k: cgi.escape(str(v)) for k, v in kwargs.items()})
AttributeError: module 'cgi' has no attribute 'escape'

Comment 1 Fedora Program Management 2021-04-29 16:19:20 UTC
This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Ben Cotton 2021-05-25 15:59:50 UTC
Fedora 32 changed to end-of-life (EOL) status on 2021-05-25. Fedora 32 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.