Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01351117-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01351117-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-17-1.fc33.src.rpm Description: This extension provides a parametrable popup menu displaying most emojis, clicking on an emoji copies it to the clipboard. An appropriate font like 'Twitter Color Emoji' or 'JoyPixels Color' should be installed on your system for a better visual result. Fedora Account System Username: carlwgeorge
Hi! This is just a question, not a review, but why aren't the locale files recompiled (using update-and-compile-translations.sh?) and why isn't there a %find_lang?
Because of my own ignorance. Thanks for the suggestion. I found the section in the packaging guidelines about handling locale files, and I'm reading that now. While I do that, do you have an example of a similar package (another gnome-shell extension ideally) that has additional languages handled correctly for me to use as a reference?
I've used dash-to-dock's spec to be sure that extensions need to follow Fedora's locale guidelines: https://src.fedoraproject.org/rpms/gnome-shell-extension-dash-to-dock/blob/master/f/gnome-shell-extension-dash-to-dock.spec But adding this should work (not sure, I didn't check thoroughly): ``` # With the requires BuildRequires: gettext # In the build section ./update-and-compile-translations.sh # At the end of %%install %find_lang emoji-selector # And add this to the %%files section %files -f emoji-selector.lang ```
Thanks for the suggestions Lyes. Since upstream is already includes the mo files in the tarball, I'll just use them directly. * Tue May 12 2020 Carl George <carl> - 19-1 - Latest upstream - Install locale files correctly Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01380479-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01380479-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-19-1.fc33.src.rpm
Hi! Sorry for this extremely late answer, I had things to take care of + a computer issue :P. I'm taking this review request! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - convenience.js has a different license. Its License ("BSD") should be added in the License Field. I was able to trace the origin of the file to this repo: https://github.com/gcampax/gnome-shell-extensions/blob/master/lib/convenience.js and to this commit: e2a76b665a1e7902d825adc7add0ad3892007d86. This file seems to be widely used in gnome extensions, as I did find the license "header" in 800+ GitHub repos (forks have surely greatly inflated that number though). And I don't think it would be right to see this as a case of bundling, since, it's not really a library, more of a single function. Plus I found 7 other packaged extensions in the repos including convenience.js, none providing a bundling declaration. So, no need to add a Provide: bundled(), adding the License is mandatory though (no need to provide a separate License file, adding BSD to the License field is enough). ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "GPL (v3 or later)". 49 files have unknown license. Detailed output of licensecheck in /var/home/lyes/Documents/reviews/1828101-gnome-shell-extension-emoji- selector/licensecheck.txt [x]: Package must own all directories that it creates. Note: this requires gnome-shell-extension-common which requires gnome-shell which requires glib2 Note: Directories without known owners: /usr/share/glib-2.0, /usr/share/glib-2.0/schemas [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-shell-extension-emoji-selector-19-1.fc33.noarch.rpm gnome-shell-extension-emoji-selector-19-1.fc33.src.rpm gnome-shell-extension-emoji-selector.noarch: W: spelling-error Summary(en_US) emojis -> emotes gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US parametrable -> penetrable, reparable, trappable gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US emojis -> emotes gnome-shell-extension-emoji-selector.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-Hans/LC_MESSAGES/emoji-selector.mo gnome-shell-extension-emoji-selector.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-Hans/LC_MESSAGES/emoji-selector.mo gnome-shell-extension-emoji-selector.src: W: spelling-error Summary(en_US) emojis -> emotes gnome-shell-extension-emoji-selector.src: W: spelling-error %description -l en_US parametrable -> penetrable, reparable, trappable gnome-shell-extension-emoji-selector.src: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular gnome-shell-extension-emoji-selector.src: W: spelling-error %description -l en_US emojis -> emotes gnome-shell-extension-emoji-selector.src: W: no-%build-section 2 packages and 0 specfiles checked; 2 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- gnome-shell-extension-emoji-selector.noarch: W: spelling-error Summary(en_US) emojis -> emotes gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US parametrable -> penetrable, reparable, trappable gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US popup -> pop up, pop-up, popular gnome-shell-extension-emoji-selector.noarch: W: spelling-error %description -l en_US emojis -> emotes gnome-shell-extension-emoji-selector.noarch: W: invalid-url URL: https://github.com/maoschanz/emoji-selector-for-gnome <urlopen error [Errno -2] Name or service not known> gnome-shell-extension-emoji-selector.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-Hans/LC_MESSAGES/emoji-selector.mo gnome-shell-extension-emoji-selector.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-Hans/LC_MESSAGES/emoji-selector.mo 1 packages and 0 specfiles checked; 2 errors, 5 warnings.
Thanks for the sleuthing on convenience.js. I've updated the license field as requested, along with a comment explaining the license breakdown. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-19-2.fc33.src.rpm
Ok! Package approved! Thank you for your work :D!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-emoji-selector
https://bodhi.fedoraproject.org/updates/FEDORA-2020-8bb0db68cd