Bug 1828119
| Summary: | OpenShift Build Image - COPY Command is Very Slow | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Michael Washer <mwasher> | |
| Component: | Containers | Assignee: | Nalin Dahyabhai <nalin> | |
| Status: | CLOSED ERRATA | QA Contact: | Weinan Liu <weinliu> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 4.3.z | CC: | adam.kaplan, aos-bugs, dwalsh, hgomes, jhou, jokerman, nalin, rmarasch, schoudha, tsweeney, wzheng, xtian | |
| Target Milestone: | --- | |||
| Target Release: | 4.6.0 | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: |
Cause: the logic that handled COPY or ADD instructions for copying content from the build context did not efficiently filter what they were copying when a .dockerignore file was present, and always behaved as though a .dockerignore file was present.
Consequence: COPY and ADD would be noticeably slowed by the cumulative overhead of evaluating whether each item in the source location should be copied to the destination, even when there was no need to perform this evaluation.
Fix: that logic was rewritten.
Result: This slowdown should no longer occur.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1833328 1952467 (view as bug list) | Environment: | ||
| Last Closed: | 2020-10-27 15:58:27 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1952467 | |||
|
Description
Michael Washer
2020-04-27 04:44:53 UTC
There are no code changes in the builder image released in 4.3.13, nor any of the core components of the build system (openshift-controller-manager, image-registry, cluster-openshift-controller-manager-operator) [1]. Can you please provide the following: 1. An example BuildConfig that reproduces the slow build times - preferably with publicly accessible source code. 2. Output build logs with the build log level set to 6 and the `--timestamps=true` option: ``` $ oc start-build mybuild --build-loglevel=6 $ oc logs build/mybuild-1 --timestamps=true ``` [1] https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.3.13 I don't have anything further, but I do know that Nalin has been devoting the majority of his time to this issue and has been making progress. Nalin do you have anything more specific to add? Nothing meaningful to add to that. We've made more progress, and the newer implementation is showing to be an improvement, but it won't be ready for merging during the current sprint. Is there anything further I can tell the customer at this stage? I know there's been more progress and there was an pre release demo the other day. I don't have a specific date for completion, but I'm hoping in the next few weeks. Nalin anything further to report? The newer implementation is still under development, and at this point the focus has moved to adding more conformance tests to exercise corner cases. I expect this effort to continue past this sprint. The newer implementation is still under development, but portions of that work have been merged into the library where that logic lives. Once it's all merged and the tests look good there, we can pull in the updated version, but I don't expect that all to be finished during this sprint. Are there any progress, plans, updates for this? There's been incremental progress and Nalin has been steadily working on this. I don't' know how to quantify the progress to date, but I do know he's continuing with this work and has been for many weeks now. I'll ask Nalin to comment if he has further info. The last large piece is now up for review for inclusion in the library that we use. Once it's merged, we'll be able to tag a release there and then pull it into the builder image. Opened https://github.com/openshift/builder/pull/172 for merging the changes. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:4196 |