Description of problem:
Polling loops return `return false, nil` when `return false, err` should be returned. See  and  for additional details.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Run e2e test for ingress or dns operator.
Moving to 4.6.
I’m adding UpcomingSprint because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.
@Miciah and I discussed this recently (github thread https://github.com/openshift/cluster-ingress-operator/pull/400#discussion_r442253985) and both came to agree that in general both the DNS and Ingress operator e2e tests should avoid hard failing on transient API or networking issues most likely caused by other cluster components. This would make it easier to actually determine which cluster component is at fault during an e2e run.
That being said, it would probably make the most sense for both of the operator's e2e polling loops to simply log API errors, should they come up, and continue returning `false, nil`, rather than hard failing by returning `false, err`.
@dhansen, does this sound reasonable to you?
I've marked my current PR's for this bugzilla as [WIP], since we are now re-thinking how we want to do this.
> @dhansen, does this sound reasonable to you?
I’m adding UpcomingSprint, because I was occupied by fixing bugs with
higher priority/severity, developing new features with higher
priority, or developing new features to improve stability at a macro
level. I will revisit this bug next sprint.
Adding upcoming sprint since this BZ's fix will be reviewed in the coming weeks.
openshift cluster-ingress-operator pull 415 needs to get rebased and openshift cluster-dns-operator pull 181 needs a /lgtm.